Skip to content

Commit 4f120bb

Browse files
committed
Address reveiw comments
Co-authored-by: kishen-v <[email protected]>
1 parent 429ab5b commit 4f120bb

File tree

1 file changed

+6
-3
lines changed
  • keps/sig-node/3953-node-resource-hot-plug

1 file changed

+6
-3
lines changed

keps/sig-node/3953-node-resource-hot-plug/README.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,9 @@ With increase in cluster resources the following components will be updated:
269269
3. Update in Node capacity.
270270

271271
4. Scheduler:
272-
* Scheduler will automatically schedule any pending pods.
273-
* This is done as an expected behavior and does not require any changes in the existing design of the scheduler, as the scheduler `watches` the
274-
available capacity of the node and creates pods accordingly.
272+
* Scheduler keeps trying to schedule any pending pods.
273+
* The scheduler `watches` the updates to available capacity of the node and schedule pods accordingly.
274+
The scheduler is already doing this today, and this KEP does not require any changes in the scheduler implementation.
275275

276276

277277
### Handling hotplug events
@@ -333,6 +333,9 @@ To ensure the Cluster Autoscaler acknowledges resource hotplug, the following ap
333333
2. Identify Nodes Affected by Hotplug:
334334
* By flagging a Node as being impacted by hotplug, the Cluster Autoscaler could revert to a less reliable but more conservative "scale from 0 nodes" logic.
335335

336+
Given that this KEP and autoscaler are inter-related, the above approaches were discussed in the community with relevant stakeholders, and have decided approaching this problem through the former route.
337+
The same will be targeted around the beta graduation of this KEP
338+
336339
### Handling HotUnplug Events
337340

338341
Though this KEP focuses only on resource hotplug, It will enable the kubelet to capture the current available capacity of the node (Regardless of whether it was a hotplug or hotunplug of resources.)

0 commit comments

Comments
 (0)