VPA: Allow e2e tests to reference a custom namespace

Enable VPA e2e tests to use a custom namespace via the VPA_NAMESPACE environment variable, while maintaining backward compatibility with the default kube-system namespace.
This addresses issue #8752 by making the e2e tests consistent with the VPA components' ability to run in custom namespaces.

Changes:
- Made VpaNamespace (e2e/v1/common.go) configurable via environment variable
- Made RecommenderNamespace (e2e/utils/common.go) configurable via environment variable
- Replaced hardcoded kube-system in deleteRecommender() function
- Replaced hardcoded kube-system in webhook RoleBinding operations

The implementation follows the same pattern as PR #7654, using environment variables with sensible defaults to enable custom configurations without breaking existing tests.

Fixes #8752

Author: AryanBagade

vertical-pod-autoscaler/e2e/utils/common.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+	"os"
 	"time"
 
 	ginkgo "github.com/onsi/ginkgo/v2"
@@ -44,8 +45,6 @@ const (
 
 	// RecommenderDeploymentName is VPA recommender deployment name
 	RecommenderDeploymentName = "vpa-recommender"
-	// RecommenderNamespace is namespace to deploy VPA recommender
-	RecommenderNamespace = "kube-system"
 	// PollInterval is interval for polling
 	PollInterval = 10 * time.Second
 	// PollTimeout is timeout for polling
@@ -57,6 +56,18 @@ const (
 	DefaultHamsterBackoffLimit = int32(10)
 )
 
+var (
+	// RecommenderNamespace is namespace to deploy VPA recommender.
+	// Can be overridden via VPA_NAMESPACE environment variable.
+	RecommenderNamespace = "kube-system"
+)
+
+func init() {
+	if ns := os.Getenv("VPA_NAMESPACE"); ns != "" {
+		RecommenderNamespace = ns
+	}
+}
+
 // HamsterTargetRef is CrossVersionObjectReference of hamster app
 var HamsterTargetRef = &autoscaling.CrossVersionObjectReference{
 	APIVersion: "apps/v1",

vertical-pod-autoscaler/e2e/utils/webhook.go

@@ -219,7 +219,7 @@ func waitWebhookConfigurationReady(f *framework.Framework) error {
 func CreateAuthReaderRoleBinding(f *framework.Framework, namespace string) {
 	ginkgo.By("Create role binding to let webhook read extension-apiserver-authentication")
 	client := f.ClientSet
-	_, err := client.RbacV1().RoleBindings("kube-system").Create(context.TODO(), &rbacv1.RoleBinding{
+	_, err := client.RbacV1().RoleBindings(RecommenderNamespace).Create(context.TODO(), &rbacv1.RoleBinding{
 		ObjectMeta: metav1.ObjectMeta{
 			Name: roleBindingName,
 			Annotations: map[string]string{
@@ -382,5 +382,5 @@ func CleanWebhookTest(client clientset.Interface, namespaceName string) {
 	_ = client.CoreV1().Services(namespaceName).Delete(context.TODO(), WebhookServiceName, metav1.DeleteOptions{})
 	_ = client.AppsV1().Deployments(namespaceName).Delete(context.TODO(), deploymentName, metav1.DeleteOptions{})
 	_ = client.CoreV1().Secrets(namespaceName).Delete(context.TODO(), WebhookServiceName, metav1.DeleteOptions{})
-	_ = client.RbacV1().RoleBindings("kube-system").Delete(context.TODO(), roleBindingName, metav1.DeleteOptions{})
+	_ = client.RbacV1().RoleBindings(RecommenderNamespace).Delete(context.TODO(), roleBindingName, metav1.DeleteOptions{})
 }

vertical-pod-autoscaler/e2e/v1/common.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+	"os"
 	"time"
 
 	ginkgo "github.com/onsi/ginkgo/v2"
@@ -53,11 +54,20 @@ const (
 	// VpaInPlaceTimeout is a timeout for the VPA to finish in-place resizing a
 	// pod, if there are no mechanisms blocking it.
 	VpaInPlaceTimeout = 2 * time.Minute
+)
 
-	// VpaNamespace is the default namespace that holds the all the VPA components.
+var (
+	// VpaNamespace is the namespace that holds the all the VPA components.
+	// Can be overridden via VPA_NAMESPACE environment variable.
 	VpaNamespace = "kube-system"
 )
 
+func init() {
+	if ns := os.Getenv("VPA_NAMESPACE"); ns != "" {
+		VpaNamespace = ns
+	}
+}
+
 // UpdaterE2eDescribe describes a VPA updater e2e test.
 func UpdaterE2eDescribe(name string, args ...interface{}) bool {
 	return utils.SIGDescribe(updateComponent, name, args...)

vertical-pod-autoscaler/e2e/v1/recommender.go

@@ -480,7 +480,7 @@ var _ = utils.RecommenderE2eDescribe("VPA CRD object", func() {
 })
 
 func deleteRecommender(c clientset.Interface) error {
-	namespace := "kube-system"
+	namespace := VpaNamespace
 	listOptions := metav1.ListOptions{}
 	podList, err := c.CoreV1().Pods(namespace).List(context.TODO(), listOptions)
 	if err != nil {