removed prev unit tests

Signed-off-by: Omer Aplatony <[email protected]>

Author: omerap12

vertical-pod-autoscaler/e2e/v1/admission_controller.go

@@ -877,170 +877,6 @@ var _ = AdmissionControllerE2eDescribe("Admission-controller", ginkgo.Label("FG:
 			vpaJSON     string
 			expectedErr string
 		}{
-			{
-				name: "Invalid oomBumpUpRatio (negative value)",
-				vpaJSON: `{
-            "apiVersion": "autoscaling.k8s.io/v1",
-            "kind": "VerticalPodAutoscaler",
-            "metadata": {"name": "oom-test-vpa"},
-            "spec": {
-                "targetRef": {
-                    "apiVersion": "apps/v1",
-                    "kind": "Deployment",
-                    "name": "oom-test"
-                },
-                "updatePolicy": {
-                    "updateMode": "Auto"
-                },
-                "resourcePolicy": {
-                    "containerPolicies": [{
-                        "containerName": "*",
-                        "oomBumpUpRatio": -1,
-                        "oomMinBumpUp": 104857600
-                    }]
-                }
-            }
-        }`,
-				expectedErr: "admission webhook \"vpa.k8s.io\" denied the request: oomBumpUpRatio must be greater than or equal to 1.0, got -1",
-			},
-			{
-				name: "Invalid oomBumpUpRatio (string value)",
-				vpaJSON: `{
-            "apiVersion": "autoscaling.k8s.io/v1",
-            "kind": "VerticalPodAutoscaler",
-            "metadata": {"name": "oom-test-vpa"},
-            "spec": {
-                "targetRef": {
-                    "apiVersion": "apps/v1",
-                    "kind": "Deployment",
-                    "name": "oom-test"
-                },
-                "updatePolicy": {
-                    "updateMode": "Auto"
-                },
-                "resourcePolicy": {
-                    "containerPolicies": [{
-                        "containerName": "*",
-                        "oomBumpUpRatio": "12",
-                        "oomMinBumpUp": 104857600
-                    }]
-                }
-            }
-        }`,
-				expectedErr: "json: cannot unmarshal string into Go struct field ContainerResourcePolicy.spec.resourcePolicy.containerPolicies.oomBumpUpRatio of type float64",
-			},
-			{
-				name: "Invalid oomBumpUpRatio (less than 1)",
-				vpaJSON: `{
-            "apiVersion": "autoscaling.k8s.io/v1",
-            "kind": "VerticalPodAutoscaler",
-            "metadata": {"name": "oom-test-vpa"},
-            "spec": {
-                "targetRef": {
-                    "apiVersion": "apps/v1",
-                    "kind": "Deployment",
-                    "name": "oom-test"
-                },
-                "updatePolicy": {
-                    "updateMode": "Auto"
-                },
-                "resourcePolicy": {
-                    "containerPolicies": [{
-                        "containerName": "*",
-                        "oomBumpUpRatio": 0.5,
-                        "oomMinBumpUp": 104857600
-                    }]
-                }
-            }
-        }`,
-				expectedErr: "spec.resourcePolicy.containerPolicies[0].oomBumpUpRatio: Invalid value: 0.5: spec.resourcePolicy.containerPolicies[0].oomBumpUpRatio in body should be greater than or equal to 1",
-			},
-			{
-				name: "Invalid oomMinBumpUp (negative value)",
-				vpaJSON: `{
-            "apiVersion": "autoscaling.k8s.io/v1",
-            "kind": "VerticalPodAutoscaler",
-            "metadata": {"name": "oom-test-vpa"},
-            "spec": {
-                "targetRef": {
-                    "apiVersion": "apps/v1",
-                    "kind": "Deployment",
-                    "name": "oom-test"
-                },
-                "updatePolicy": {
-                    "updateMode": "Auto"
-                },
-                "resourcePolicy": {
-                    "containerPolicies": [{
-                        "containerName": "*",
-                        "oomBumpUpRatio": 2,
-                        "oomMinBumpUp": -1
-                    }]
-                }
-            }
-        }`,
-				expectedErr: "spec.resourcePolicy.containerPolicies[0].oomMinBumpUp: Invalid value: -1: spec.resourcePolicy.containerPolicies[0].oomMinBumpUp in body should be greater than or equal to 0",
-			},
-			{
-				name: "Invalid evictAfterOOMThreshold (negative duration)",
-				vpaJSON: `{
-		"apiVersion": "autoscaling.k8s.io/v1",
-		"kind": "VerticalPodAutoscaler",
-		"metadata": {"name": "evict-threshold-vpa"},
-		"spec": {
-			"targetRef": {
-				"apiVersion": "apps/v1",
-				"kind": "Deployment",
-				"name": "hamster"
-			},
-			"updatePolicy": {
-				"updateMode": "Auto",
-				"evictAfterOOMThreshold": "-5m"
-			}
-		}
-	}`,
-				expectedErr: "spec.updatePolicy.evictAfterOOMThreshold: Invalid value:.*evictAfterOOMThreshold must be greater equal to 0",
-			},
-			{
-				name: "Invalid evictAfterOOMThreshold (invalid format)",
-				vpaJSON: `{
-		"apiVersion": "autoscaling.k8s.io/v1",
-		"kind": "VerticalPodAutoscaler",
-		"metadata": {"name": "evict-threshold-vpa"},
-		"spec": {
-			"targetRef": {
-				"apiVersion": "apps/v1",
-				"kind": "Deployment",
-				"name": "hamster"
-			},
-			"updatePolicy": {
-				"updateMode": "Auto",
-				"evictAfterOOMThreshold": "not-a-duration"
-			}
-		}
-	}`,
-				expectedErr: "spec.updatePolicy.evictAfterOOMThreshold.*invalid duration",
-			},
-			{
-				name: "Invalid evictAfterOOMThreshold (invalid unit)",
-				vpaJSON: `{
-		"apiVersion": "autoscaling.k8s.io/v1",
-		"kind": "VerticalPodAutoscaler",
-		"metadata": {"name": "evict-threshold-vpa"},
-		"spec": {
-			"targetRef": {
-				"apiVersion": "apps/v1",
-				"kind": "Deployment",
-				"name": "hamster"
-			},
-			"updatePolicy": {
-				"updateMode": "Auto",
-				"evictAfterOOMThreshold": "5x"
-			}
-		}
-	}`,
-				expectedErr: "spec.updatePolicy.evictAfterOOMThreshold.*Pattern",
-			},
 			{
 				name: "Invalid minAllowed (invalid requests field)",
 				vpaJSON: `{