Skip to content

Commit 18d8efd

Browse files
authored
Merge pull request #8797 from kamarabbas99/clean_fix_for_experimental
Fix test failure after rebase
2 parents b25e43c + 3512961 commit 18d8efd

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

vertical-pod-autoscaler/e2e/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ require (
1212
github.com/onsi/gomega v1.38.2
1313
k8s.io/api v0.34.0
1414
k8s.io/apimachinery v0.34.0
15+
k8s.io/apiserver v0.34.0
1516
k8s.io/autoscaler/vertical-pod-autoscaler v1.4.1
1617
k8s.io/client-go v0.34.0
1718
k8s.io/component-base v0.34.0
@@ -140,7 +141,6 @@ require (
140141
gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
141142
gopkg.in/yaml.v3 v3.0.1 // indirect
142143
k8s.io/apiextensions-apiserver v0.34.0 // indirect
143-
k8s.io/apiserver v0.34.0 // indirect
144144
k8s.io/cloud-provider v0.34.0 // indirect
145145
k8s.io/component-helpers v0.34.0 // indirect
146146
k8s.io/controller-manager v0.34.0 // indirect

vertical-pod-autoscaler/pkg/updater/logic/updater.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,11 +284,11 @@ func (u *updater) RunOnce(ctx context.Context) {
284284
err := inPlaceLimiter.InPlaceUpdate(pod, vpa, u.eventRecorder)
285285
if err != nil {
286286
klog.V(0).InfoS("Unboosting failed", "error", err, "pod", klog.KObj(pod))
287-
metrics_updater.RecordFailedInPlaceUpdate(vpaSize, "UnboostError")
287+
metrics_updater.RecordFailedInPlaceUpdate(vpaSize, vpa.Name, vpa.Namespace, "UnboostError")
288288
} else {
289289
klog.V(2).InfoS("Successfully unboosted pod", "pod", klog.KObj(pod))
290290
withInPlaceUpdated = true
291-
metrics_updater.AddInPlaceUpdatedPod(vpaSize)
291+
metrics_updater.AddInPlaceUpdatedPod(vpaSize, vpa.Name, vpa.Namespace)
292292
}
293293
}
294294
}

0 commit comments

Comments
 (0)