plugin/label: Suggest members to assign label

Provide a breadcrumb to users if they are unable to assign a label *and*
there are no allowed_teams configured.

Signed-off-by: Stephen Finucane <[email protected]>

Author: stephenfin

pkg/plugins/label/label.go

@@ -18,6 +18,7 @@ package label
 
 import (
 	"fmt"
+	"math/rand/v2"
 	"regexp"
 	"strings"
 
@@ -334,7 +335,14 @@ func canUserSetLabel(ghc githubClient, org string, user string, label string, re
 
 	msg := fmt.Sprintf("The label(s) `%s` cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user.", label)
 	if len(config.AllowedTeams) > 0 {
-		msg += fmt.Sprintf(" Must be a member of one of these teams: %v", strings.Join(config.AllowedTeams, ", "))
+		msg += fmt.Sprintf(" Must be a member of one of these teams: %s", strings.Join(config.AllowedTeams, ", "))
+	} else if len(config.AllowedUsers) > 0 {
+		randomUsers := []string{}
+		// Just in case we have some very large teams, we only show up to 20 users.
+		for userIdx := range rand.Perm(len(config.AllowedUsers))[:min(len(config.AllowedUsers), 20)] {
+			randomUsers = append(randomUsers, config.AllowedUsers[userIdx])
+		}
+		msg += fmt.Sprintf(" Consider assigning one of the following members: %s", strings.Join(randomUsers, ","))
 	}
 	return false, msg, nil
 }

pkg/plugins/label/label_test.go

@@ -718,7 +718,7 @@ func TestHandleComment(t *testing.T) {
 			restrictedLabels:    map[string][]plugins.RestrictedLabel{"org": {{Label: "restricted-label", AllowedUsers: []string{orgMemberAlt}}}},
 			action:              github.GenericCommentActionCreated,
 			expectedBotComment:  true,
-			expectedCommentText: "The label(s) `restricted-label` cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user.",
+			expectedCommentText: "The label(s) `restricted-label` cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Consider assigning one of the following members: Mallory",
 		},
 		{
 			name:              "Restricted label addition, user is in allowed_teams",
@@ -759,7 +759,7 @@ func TestHandleComment(t *testing.T) {
 			restrictedLabels:    map[string][]plugins.RestrictedLabel{"org": {{Label: "restricted-label", AllowedUsers: []string{orgMemberAlt}}}},
 			action:              github.GenericCommentActionCreated,
 			expectedBotComment:  true,
-			expectedCommentText: "The label(s) `restricted-label` cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user.",
+			expectedCommentText: "The label(s) `restricted-label` cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Consider assigning one of the following members: Mallory",
 		},
 		{
 			name:                  "Restricted label removal, user is in allowed_teams",