Skip to content

Commit b4f6613

Browse files
committed
Fix some trigger unit test descriptions
Some tests were described as "<COMMENT-TEXT> results in <BOT-ACTION>" and some were described as "<COMMENT-TEXT> in <CONTEXT> [has no effect]", but some of the latter erroneously had the word "results" in them as though that was part of the comment text.
1 parent 99d79e9 commit b4f6613

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pkg/plugins/trigger/generic-comment_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,15 +1087,15 @@ func TestHandleGenericComment(t *testing.T) {
10871087
AddedComment: pjutil.TestWithoutTargetNote + helpComment + helpTestAllWithJobsComment,
10881088
},
10891089
{
1090-
name: "ignore `/test` with no target results in a code block",
1090+
name: "ignore `/test` with no target in a code block",
10911091
Author: "trusted-member",
10921092
Body: "```\n/test\n```",
10931093
State: "open",
10941094
IsPR: true,
10951095
AddedComment: shouldNotAddComment,
10961096
},
10971097
{
1098-
name: "ignore `/test` with no target results in a tilda code block",
1098+
name: "ignore `/test` with no target in a tilde code block",
10991099
Author: "trusted-member",
11001100
Body: "~~~\n/test\n~~~",
11011101
State: "open",
@@ -1119,7 +1119,7 @@ func TestHandleGenericComment(t *testing.T) {
11191119
AddedComment: pjutil.RetestWithTargetNote + helpComment + helpTestAllWithJobsComment,
11201120
},
11211121
{
1122-
name: "/retest with trailing words results in a code block",
1122+
name: "/retest with trailing words in a code block",
11231123
Author: "trusted-member",
11241124
Body: produceCodeBlock("/retest FOO", false),
11251125
State: "open",
@@ -1144,23 +1144,23 @@ func TestHandleGenericComment(t *testing.T) {
11441144
AddedComment: pjutil.TargetNotFoundNote + helpComment + helpTestAllWithJobsComment,
11451145
},
11461146
{
1147-
name: "/test with unknown target results in code block. Should be ignored",
1147+
name: "/test with unknown target in code block. Should be ignored",
11481148
Author: "trusted-member",
11491149
Body: produceCodeBlock("/test FOO", false),
11501150
State: "open",
11511151
IsPR: true,
11521152
AddedComment: shouldNotAddComment,
11531153
},
11541154
{
1155-
name: "two `/test` with unknown target results. One in a code block, and one is not.",
1155+
name: "two `/test` with unknown target. One in a code block, and one is not.",
11561156
Author: "trusted-member",
11571157
Body: produceCodeBlock("/test FOO", true) + "/test BAR",
11581158
State: "open",
11591159
IsPR: true,
11601160
AddedComment: pjutil.TargetNotFoundNote + helpComment + helpTestAllWithJobsComment,
11611161
},
11621162
{
1163-
name: "two `/test` with unknown target results. One out of a code block, and one is inside.",
1163+
name: "two `/test` with unknown target. One out of a code block, and one is inside.",
11641164
Author: "trusted-member",
11651165
Body: "/test FOO\n" + produceCodeBlock("/test BAR", false),
11661166
State: "open",

0 commit comments

Comments
 (0)