Merge pull request #456 from stephenfin/unhold-with-description

Allow reason with /unhold too

Author: k8s-ci-robot

pkg/plugins/hold/hold.go

@@ -40,7 +40,7 @@ const (
 
 var (
 	labelRe       = regexp.MustCompile(`(?mi)^/hold(\s.*)?$`)
-	labelCancelRe = regexp.MustCompile(`(?mi)^/(remove-hold|hold\s+cancel|unhold)\s*$`)
+	labelCancelRe = regexp.MustCompile(`(?mi)^/(remove-hold|hold\s+cancel|unhold)(\s.*)?$`)
 )
 
 type hasLabelFunc func(label string, issueLabels []github.Label) bool

pkg/plugins/hold/hold_test.go

@@ -93,8 +93,8 @@ func TestHandle(t *testing.T) {
 			isPR:          true,
 		},
 		{
-			name:          "requested hold cancel with whitespace",
-			body:          "/hold   cancel  ",
+			name:          "requested hold cancel with a reason",
+			body:          "/hold   cancel  further review has happened and I have whitespace",
 			hasLabel:      true,
 			shouldLabel:   false,
 			shouldUnlabel: true,
@@ -117,8 +117,8 @@ func TestHandle(t *testing.T) {
 			isPR:          true,
 		},
 		{
-			name:          "requested unhold with whitespace",
-			body:          "/unhold    ",
+			name:          "requested unhold with a reason",
+			body:          "/unhold   further review has happened and I have whitespace",
 			hasLabel:      true,
 			shouldLabel:   false,
 			shouldUnlabel: true,