Commit 0156f6c
committed
Fix
This commit resolves a naming conflict in integration tests where the "TestUpdate" kind
was being used in both the Update and CRD test suites, causing test failures due to
conflicting CRD definitions.
While fixing this, I noticed we should be more careful about resource ownership in general.
kro should respect ownership labels not just for CRDs but for all managed resources.
Before modifying any resource (CRD or managed resources), we should verify its actually
"ours" by checking the ownership labels. This would prevent the exact type of conflict we
saw here, where one RGD might accidentally modify resources that belong to other RGDs.TestInstanceUpdate kind name conflicts in integration tests (#553)1 parent 34fdba2 commit 0156f6c
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| |||
0 commit comments