Skip to content

Commit b975bbb

Browse files
authored
Merge pull request #2779 from BenTheElder/precision-versions
use precise versions for kubeadm label / taint changes
2 parents 1e2f525 + ccddd49 commit b975bbb

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pkg/cluster/internal/create/actions/kubeadminit/init.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,10 @@ func (a *action) Execute(ctx *actions.ActionContext) error {
122122
return errors.Wrap(err, "could not parse Kubernetes version")
123123
}
124124
var taints []string
125-
if kubeVersion.LessThan(version.MustParseSemantic("v1.24.0-0")) {
125+
if kubeVersion.LessThan(version.MustParseSemantic("v1.24.0-alpha.1.592+370031cadac624")) {
126126
// for versions older than 1.24 prerelease remove only the old taint
127127
taints = []string{"node-role.kubernetes.io/master-"}
128-
} else if kubeVersion.LessThan(version.MustParseSemantic("v1.25.0-0")) {
128+
} else if kubeVersion.LessThan(version.MustParseSemantic("v1.25.0-alpha.0.557+84c8afeba39ec9")) {
129129
// for versions between 1.24 and 1.25 prerelease remove both the old and new taint
130130
taints = []string{"node-role.kubernetes.io/control-plane-", "node-role.kubernetes.io/master-"}
131131
} else {

pkg/cluster/internal/create/actions/waitforready/waitforready.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ func (a *Action) Execute(ctx *actions.ActionContext) error {
8080
return errors.Wrap(err, "could not parse Kubernetes version")
8181
}
8282
selectorLabel := "node-role.kubernetes.io/control-plane"
83-
if kubeVersion.LessThan(version.MustParseSemantic("v1.24.0")) {
83+
if kubeVersion.LessThan(version.MustParseSemantic("v1.24.0-alpha.1.591+a3d5e5598290df")) {
8484
selectorLabel = "node-role.kubernetes.io/master"
8585
}
8686

0 commit comments

Comments
 (0)