default data cache enabled to false

[Sneha-at]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:
We recently had an issue where data cache related watcher was running on non-data cache nodes as we were defaulting to true so updating the default values here to false
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Disabling data cache watcher by default if node details are not available.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sneha-at
Once this PR has been reviewed and has the lgtm label, please assign pwschuurman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sunnylovestiramisu]

Should we also add *enableDataCacheFlag and len(nodeName) > 0 && nodeName != common.TestNode above?

This logic does not seem correct for gating component versions with the enableDataCacheFlag.

Should we have some unit tests for this coverage?

[sunnylovestiramisu]

Actually expanded the code above the flag check was ahead.

[sunnylovestiramisu]

Any other possibility that the nodeName maybe empty other than the bug that we already knew?

[pwschuurman]

Don't we want data cache to be enabled for E2E testing? I think there's 3 scenarios here:

• nodeName empty (false)
• nodeName is testnode (true)
• nodeName is set (check LSSD from label)

Also, would it be good to consolidate the enable/disable logic somewhere (eg: in a feature flags class), so that all codepaths are routed through the same enablement behavior? I'm thinking about the NodeUnstage case, where we aren't checking if this is a data cache enabled node.

[k8s-ci-robot]

@Sneha-at: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gcp-compute-persistent-disk-csi-driver-sanity	0710ba6	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-sanity
pull-gcp-compute-persistent-disk-csi-driver-unit	0710ba6	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-unit
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration	0710ba6	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
pull-gcp-compute-persistent-disk-csi-driver-verify	0710ba6	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-verify
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022	0710ba6	link	false	/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019	0710ba6	link	false	/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019
pull-gcp-compute-persistent-disk-csi-driver-e2e	0710ba6	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.