Address Stefan comments (conversion)

Signed-off-by: Furkat Gofurov <[email protected]>

Author: furkatgofurov7

internal/api/core/v1alpha3/conversion.go

@@ -98,13 +98,6 @@ func (src *Cluster) ConvertTo(dstRaw conversion.Hub) error {
 	if err != nil {
 		return err
 	}
-	// Recover unhealthyMachineConditions for control plane and machine deployments
-	dst.Spec.Topology.ControlPlane.HealthCheck.Checks.UnhealthyMachineConditions = restored.Spec.Topology.ControlPlane.HealthCheck.Checks.UnhealthyMachineConditions
-	for i, md := range restored.Spec.Topology.Workers.MachineDeployments {
-		if i < len(dst.Spec.Topology.Workers.MachineDeployments) {
-			dst.Spec.Topology.Workers.MachineDeployments[i].HealthCheck.Checks.UnhealthyMachineConditions = md.HealthCheck.Checks.UnhealthyMachineConditions
-		}
-	}
 
 	// Recover intent for bool values converted to *bool.
 	clusterv1.Convert_bool_To_Pointer_bool(src.Spec.Paused, ok, restored.Spec.Paused, &dst.Spec.Paused)

internal/api/core/v1alpha3/conversion_test.go

@@ -417,7 +417,6 @@ func spokeCluster(in *Cluster, c randfill.Continue) {
 func MachineHealthCheckFuzzFunc(_ runtimeserializer.CodecFactory) []interface{} {
 	return []interface{}{
 		hubMachineHealthCheckStatus,
-		hubMachineHealthCheckSpec,
 		hubUnhealthyNodeCondition,
 		spokeMachineHealthCheck,
 		spokeMachineHealthCheckSpec,
@@ -426,15 +425,6 @@ func MachineHealthCheckFuzzFunc(_ runtimeserializer.CodecFactory) []interface{}
 	}
 }
 
-func hubMachineHealthCheckSpec(in *clusterv1.MachineHealthCheckSpec, c randfill.Continue) {
-	c.FillNoCustom(in)
-
-	// Drop UnhealthyMachineConditions as it does not exist in v1alpha3.
-	if in.Checks.UnhealthyMachineConditions != nil {
-		in.Checks.UnhealthyMachineConditions = nil
-	}
-}
-
 func hubMachineHealthCheckStatus(in *clusterv1.MachineHealthCheckStatus, c randfill.Continue) {
 	c.FillNoCustom(in)
 	// Drop empty structs with only omit empty fields.

internal/api/core/v1alpha4/conversion.go

@@ -92,11 +92,6 @@ func (src *Cluster) ConvertTo(dstRaw conversion.Hub) error {
 		return err
 	}
 
-	dst.Spec.Topology.ControlPlane.HealthCheck.Checks.UnhealthyMachineConditions = restored.Spec.Topology.ControlPlane.HealthCheck.Checks.UnhealthyMachineConditions
-	for i, md := range restored.Spec.Topology.Workers.MachineDeployments {
-		dst.Spec.Topology.Workers.MachineDeployments[i].HealthCheck.Checks.UnhealthyMachineConditions = md.HealthCheck.Checks.UnhealthyMachineConditions
-	}
-
 	// Recover intent for bool values converted to *bool.
 	clusterv1.Convert_bool_To_Pointer_bool(src.Spec.Paused, ok, restored.Spec.Paused, &dst.Spec.Paused)
 
@@ -242,11 +237,6 @@ func (src *ClusterClass) ConvertTo(dstRaw conversion.Hub) error {
 		return err
 	}
 
-	dst.Spec.ControlPlane.HealthCheck.Checks.UnhealthyMachineConditions = restored.Spec.ControlPlane.HealthCheck.Checks.UnhealthyMachineConditions
-	for i, md := range restored.Spec.Workers.MachineDeployments {
-		dst.Spec.Workers.MachineDeployments[i].HealthCheck.Checks.UnhealthyMachineConditions = md.HealthCheck.Checks.UnhealthyMachineConditions
-	}
-
 	dst.Spec.Patches = restored.Spec.Patches
 	dst.Spec.Variables = restored.Spec.Variables
 	dst.Spec.AvailabilityGates = restored.Spec.AvailabilityGates

internal/api/core/v1alpha4/conversion_test.go

@@ -486,7 +486,6 @@ func spokeMachineDeploymentSpec(in *MachineDeploymentSpec, c randfill.Continue)
 func MachineHealthCheckFuzzFunc(_ runtimeserializer.CodecFactory) []interface{} {
 	return []interface{}{
 		hubMachineHealthCheckStatus,
-		hubMachineHealthCheckSpec,
 		hubUnhealthyNodeCondition,
 		spokeMachineHealthCheck,
 		spokeMachineHealthCheckSpec,
@@ -495,15 +494,6 @@ func MachineHealthCheckFuzzFunc(_ runtimeserializer.CodecFactory) []interface{}
 	}
 }
 
-func hubMachineHealthCheckSpec(in *clusterv1.MachineHealthCheckSpec, c randfill.Continue) {
-	c.FillNoCustom(in)
-
-	// Drop UnhealthyMachineConditions as it does not exist in v1alpha4.
-	if in.Checks.UnhealthyMachineConditions != nil {
-		in.Checks.UnhealthyMachineConditions = nil
-	}
-}
-
 func hubMachineHealthCheckStatus(in *clusterv1.MachineHealthCheckStatus, c randfill.Continue) {
 	c.FillNoCustom(in)
 	// Drop empty structs with only omit empty fields.