Skip to content

Commit 4ed0fa3

Browse files
committed
third review update
1 parent 09c6ea4 commit 4ed0fa3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/proposals/20250513-propogate-taints.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ This ensures that a node ever only gets these taints added once, at the time of
495495

496496
If a Node re-registers itself, the controllers also would again add the `OnInitialization` as well as the `Always` taints because the tracking annotation does not exist.
497497

498-
**Note:** If a bootstrap provider supports the `node.cluster.x-k8s.io/uninitialized` taint as documented in [Contract rules for BootstrapConfig](https://cluster-api.sigs.k8s.io/developer/providers/contracts/bootstrap-config#taint-nodes-at-creation), this taint ensures that no workload will be scheduled until the node was initialized, unless the workload defines proper tolerations.
498+
**Note:** If a bootstrap provider supports the `node.cluster.x-k8s.io/uninitialized` taint as documented in [Contract rules for BootstrapConfig](https://cluster-api.sigs.k8s.io/developer/providers/contracts/bootstrap-config#taint-nodes-at-creation), the implementation ensures that all `OnInitialization` taints are applied at the same time as the `node.cluster.x-k8s.io/uninitialized` is getting removed. This prevents that workload without proper tolerations could be scheduled to the node in the time between node creation and Cluster API adding the `OnInitialization` taints.
499499

500500
**Note 2:** A taint added by a bootstrap provider (e.g. CABPK) will be treated as a taint added by any other actor and will not get special handling. Especially for an `Always` taint this means the machine controller would adopt the taint and start tracking it.
501501

0 commit comments

Comments
 (0)