address review comments

Author: arshadd-b

internal/controllers/machine/machine_controller_test.go

@@ -3777,7 +3777,6 @@ func TestNodeDeletionWithHooks(t *testing.T) {
 		name                 string
 		deletionTimeout      *metav1.Duration
 		resultErr            bool
-		clusterDeleted       bool
 		expectNodeDeletion   bool
 		expectDeletingReason string
 		annotations          map[string]string
@@ -3823,7 +3822,7 @@ func TestNodeDeletionWithHooks(t *testing.T) {
 			expectNodeDeletion:   false,
 			expectDeletingReason: clusterv1.MachineDeletingDrainingNodeV1Beta2Reason,
 			annotations: map[string]string{
-				"machine.cluster.x-k8s.io": "",
+				"machine.cluster.x-k8s.io/exclude-wait-for-node-volume-detach": "",
 			},
 			createFakeClient: func(initObjs ...client.Object) client.Client {
 				return fake.NewClientBuilder().
@@ -3852,13 +3851,8 @@ func TestNodeDeletionWithHooks(t *testing.T) {
 				reconcileDeleteCache:     cache.New[cache.ReconcileEntry](),
 			}
 
-			cluster := testCluster.DeepCopy()
-			if tc.clusterDeleted {
-				cluster.DeletionTimestamp = &metav1.Time{Time: deletionTime.Add(time.Hour)}
-			}
-
 			s := &scope{
-				cluster:                   cluster,
+				cluster:                   &testCluster,
 				machine:                   m,
 				infraMachineIsNotFound:    true,
 				bootstrapConfigIsNotFound: true,
@@ -3904,7 +3898,7 @@ func TestNodeDeletionWithPreDrainHook(t *testing.T) {
 				clusterv1.MachineControlPlaneLabel: "",
 			},
 			Annotations: map[string]string{
-				"machine.cluster.x-k8s.io": "",
+				"machine.cluster.x-k8s.io/exclude-wait-for-node-volume-detach": "",
 			},
 			Finalizers:        []string{clusterv1.MachineFinalizer},
 			DeletionTimestamp: &metav1.Time{Time: deletionTime},
@@ -3952,7 +3946,6 @@ func TestNodeDeletionWithPreDrainHook(t *testing.T) {
 		name                 string
 		deletionTimeout      *metav1.Duration
 		resultErr            bool
-		clusterDeleted       bool
 		expectNodeDeletion   bool
 		expectDeletingReason string
 		pods                 []*corev1.Pod
@@ -4041,13 +4034,8 @@ func TestNodeDeletionWithPreDrainHook(t *testing.T) {
 				reconcileDeleteCache:     cache.New[cache.ReconcileEntry](),
 			}
 
-			cluster := testCluster.DeepCopy()
-			if tc.clusterDeleted {
-				cluster.DeletionTimestamp = &metav1.Time{Time: deletionTime.Add(time.Hour)}
-			}
-
 			s := &scope{
-				cluster:                   cluster,
+				cluster:                   &testCluster,
 				machine:                   m,
 				infraMachineIsNotFound:    true,
 				bootstrapConfigIsNotFound: true,
@@ -4210,13 +4198,8 @@ func TestNodeDeletionWithInfraAndBootstrap(t *testing.T) {
 				reconcileDeleteCache:     cache.New[cache.ReconcileEntry](),
 			}
 
-			cluster := testCluster.DeepCopy()
-			if tc.clusterDeleted {
-				cluster.DeletionTimestamp = &metav1.Time{Time: deletionTime.Add(time.Hour)}
-			}
-
 			s := &scope{
-				cluster:                   cluster,
+				cluster:                   &testCluster,
 				machine:                   m,
 				infraMachineIsNotFound:    tc.infraMachineFound,
 				infraMachine:              tc.infraMachine,
@@ -4364,7 +4347,6 @@ func TestNodeDeletionWithVolumeDetach(t *testing.T) {
 		deletionTimeout      *metav1.Duration
 		resultErr            bool
 		remoteObjects        []client.Object
-		clusterDeleted       bool
 		expectNodeDeletion   bool
 		expectDeletingReason string
 		createFakeClient     func(...client.Object) client.Client
@@ -4455,13 +4437,8 @@ func TestNodeDeletionWithVolumeDetach(t *testing.T) {
 				reconcileDeleteCache:     cache.New[cache.ReconcileEntry](),
 			}
 
-			cluster := testCluster.DeepCopy()
-			if tc.clusterDeleted {
-				cluster.DeletionTimestamp = &metav1.Time{Time: deletionTime.Add(time.Hour)}
-			}
-
 			s := &scope{
-				cluster:                   cluster,
+				cluster:                   &testCluster,
 				machine:                   m,
 				infraMachineIsNotFound:    true,
 				bootstrapConfigIsNotFound: true,