Skip to content

Commit bf3b0e3

Browse files
authored
Merge pull request #3077 from chrischdi/pr-makefile-pin-controller-gen-go
[release-1.10] 🌱 Makefile: pin controller-gen binary to go 1.21
2 parents eb41588 + 974146e commit bf3b0e3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -983,7 +983,8 @@ $(IMPORT_BOSS_BIN): $(IMPORT_BOSS)
983983
$(RELEASE_NOTES_BIN): $(RELEASE_NOTES) ## Build a local copy of release-notes.
984984

985985
$(CONTROLLER_GEN): # Build controller-gen.
986-
GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) $(CONTROLLER_GEN_PKG) $(CONTROLLER_GEN_BIN) $(CONTROLLER_GEN_VER)
986+
# controller-gen 0.13 cannot be built with Go >= 1.22. We have to pin it to 1.21.
987+
GOTOOLCHAIN=go1.21.11 GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) $(CONTROLLER_GEN_PKG) $(CONTROLLER_GEN_BIN) $(CONTROLLER_GEN_VER)
987988

988989
## We are forcing a rebuilt of conversion-gen via PHONY so that we're always using an up-to-date version.
989990
## We can't use a versioned name for the binary, because that would be reflected in generated files.

0 commit comments

Comments
 (0)