Skip to content

Commit a88b442

Browse files
authored
Merge pull request #598 from andrewsykim/quick-start
Fixes to CAPV Docs
2 parents 2aca664 + 36cee62 commit a88b442

File tree

2 files changed

+11
-28
lines changed

2 files changed

+11
-28
lines changed

docs/getting_started.md

Lines changed: 10 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export VSPHERE_PASSWORD='some-secure-password' # (required) The password used t
9595
export VSPHERE_DATACENTER='SDDC-Datacenter' # (required) The vSphere datacenter to deploy the management cluster on
9696
export VSPHERE_DATASTORE='DefaultDatastore' # (required) The vSphere datastore to deploy the management cluster on
9797
export VSPHERE_NETWORK='vm-network-1' # (required) The VM network to deploy the management cluster on
98-
export VSPHERE_RESOURCE_POOL='Resources' # (required) The vSphere resource pool for your VMs
98+
export VSPHERE_RESOURCE_POOL='*/Resources' # (required) The vSphere resource pool for your VMs
9999
export VSPHERE_FOLDER='vm' # (optional) The VM folder for your VMs, defaults to the root vSphere folder if not set.
100100
export VSPHERE_TEMPLATE='ubuntu-1804-kube-v1.15.3' # (required) The VM template to use for your management cluster.
101101
export VSPHERE_DISK_GIB='50' # (optional) The VM Disk size in GB, defaults to 20 if not set
@@ -228,7 +228,7 @@ spec:
228228
datacenter: SDDC-Datacenter
229229
datastore: DefaultDatastore
230230
folder: vm
231-
resourcePool: Resources
231+
resourcePool: '*/Resources'
232232
server: 10.0.0.1
233233
server: 10.0.0.1
234234
```
@@ -245,36 +245,16 @@ spec:
245245
clusterConfiguration:
246246
apiServer:
247247
extraArgs:
248-
cloud-config: /etc/kubernetes/vsphere.conf
249-
cloud-provider: vsphere
250-
extraVolumes:
251-
- hostPath: /etc/kubernetes/vsphere.conf
252-
mountPath: /etc/kubernetes/vsphere.conf
253-
name: cloud-config
254-
pathType: File
255-
readOnly: true
248+
cloud-provider: external
256249
controllerManager:
257250
extraArgs:
258-
cloud-config: /etc/kubernetes/vsphere.conf
259-
cloud-provider: vsphere
260-
extraVolumes:
261-
- hostPath: /etc/kubernetes/vsphere.conf
262-
mountPath: /etc/kubernetes/vsphere.conf
263-
name: cloud-config
264-
pathType: File
265-
readOnly: true
266-
files:
267-
- content: |
268-
W0dsb2JhbF0Kc2VjcmV0LW5hbWUgPSAiY2xvdWQtcHJvdmlkZXItdnNwaGVyZS1jcmVkZW50aWFscyIKc2VjcmV0LW5hbWVzcGFjZSA9ICJrdWJlLXN5c3RlbSIKZGF0YWNlbnRlcnMgPSAiU0REQy1EYXRhY2VudGVyIgppbnNlY3VyZS1mbGFnID0gIjEiCgpbVmlydHVhbENlbnRlciAiMTAuMC4wLjFdCgpbV29ya3NwYWNlXQpzZXJ2ZXIgPSAiMTAuMC4wLjEiCmRhdGFjZW50ZXIgPSAiU0REQy1EYXRhY2VudGVyIgpmb2xkZXIgPSAidm0iCmRlZmF1bHQtZGF0YXN0b3JlID0gIkRlZmF1bHREYXRhc3RvcmUiCnJlc291cmNlcG9vbC1wYXRoID0gIlJlc291cmNlcyIKCltEaXNrXQpzY3NpY29udHJvbGxlcnR5cGUgPSBwdnNjc2kKCltOZXR3b3JrXQpwdWJsaWMtbmV0d29yayA9ICJ2bS1uZXR3b3JrLTEiCg==
269-
encoding: base64
270-
owner: root:root
271-
path: /etc/kubernetes/vsphere.conf
272-
permissions: "0600"
251+
cloud-provider: external
252+
imageRepository: k8s.gcr.io
273253
initConfiguration:
274254
nodeRegistration:
275255
criSocket: /var/run/containerd/containerd.sock
276256
kubeletExtraArgs:
277-
cloud-provider: vsphere
257+
cloud-provider: external
278258
name: '{{ ds.meta_data.hostname }}'
279259
preKubeadmCommands:
280260
- hostname "{{ ds.meta_data.hostname }}"
@@ -312,6 +292,9 @@ spec:
312292
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha2
313293
kind: VSphereMachine
314294
metadata:
295+
labels:
296+
cluster.x-k8s.io/cluster-name: workload-cluster-1
297+
cluster.x-k8s.io/control-plane: "true"
315298
name: workload-cluster-1-controlplane-0
316299
namespace: default
317300
spec:
@@ -342,7 +325,7 @@ spec:
342325
nodeRegistration:
343326
criSocket: /var/run/containerd/containerd.sock
344327
kubeletExtraArgs:
345-
cloud-provider: vsphere
328+
cloud-provider: external
346329
name: '{{ ds.meta_data.hostname }}'
347330
preKubeadmCommands:
348331
- hostname "{{ ds.meta_data.hostname }}"

examples/default/machinedeployment/machinedeployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ spec:
5555
name: "{{ ds.meta_data.hostname }}"
5656
criSocket: "/var/run/containerd/containerd.sock"
5757
kubeletExtraArgs:
58-
cloud-provider: vsphere
58+
cloud-provider: external
5959
users:
6060
- name: capv
6161
sudo: "ALL=(ALL) NOPASSWD:ALL"

0 commit comments

Comments
 (0)