fix: use vsphereMachine instead of machine for fd

This commit changes the failureDomain check from
using capi machine to vsphereMachine.
The vsphereMachine object has immediate access
to the failure domain struct, which resolves
an issue where virtual machines are not placed
within vm-host groups in a timely
manner causing misplacement in the topology.

Author: jcpowermac

controllers/vspherevm_controller.go

@@ -234,10 +234,10 @@ func (r vmReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.R
 	}
 
 	var vsphereFailureDomain *infrav1.VSphereFailureDomain
-	if failureDomain := machine.Spec.FailureDomain; failureDomain != "" {
+	if failureDomain := vsphereMachine.Spec.FailureDomain; failureDomain != nil && *failureDomain != "" {
 		vsphereDeploymentZone := &infrav1.VSphereDeploymentZone{}
-		if err := r.Client.Get(ctx, apitypes.NamespacedName{Name: failureDomain}, vsphereDeploymentZone); err != nil {
-			return reconcile.Result{}, errors.Wrapf(err, "failed to get VSphereDeploymentZone %s", failureDomain)
+		if err := r.Client.Get(ctx, apitypes.NamespacedName{Name: *failureDomain}, vsphereDeploymentZone); err != nil {
+			return reconcile.Result{}, errors.Wrapf(err, "failed to get VSphereDeploymentZone %s", *failureDomain)
 		}
 
 		vsphereFailureDomain = &infrav1.VSphereFailureDomain{}