Fix UT failure

Author: DanielXiao

controllers/vmware/virtualmachinegroup_reconciler_test.go

@@ -207,15 +207,16 @@ func TestGenerateVirtualMachineGroupAnnotations(t *testing.T) {
 	}{
 		{
 			name: "Placement found for two distinct MDs",
-			vmg: &vmoprv1.VirtualMachineGroup{
-				ObjectMeta: baseVMG.ObjectMeta,
-				Status: vmoprv1.VirtualMachineGroupStatus{
+			vmg: func() *vmoprv1.VirtualMachineGroup {
+				v := baseVMG.DeepCopy()
+				v.Status = vmoprv1.VirtualMachineGroupStatus{
 					Members: []vmoprv1.VirtualMachineGroupMemberStatus{
 						newVMGMemberStatus(vsmName1, "VirtualMachine", true, true, zoneA),
 						newVMGMemberStatus(vsmName2, "VirtualMachine", true, true, zoneB),
 					},
-				},
-			},
+				}
+				return v
+			}(),
 			machineDeployments:   []string{mdName1, mdName2},
 			initialClientObjects: []client.Object{vsm1, vsm2},
 			expectedAnnotations: map[string]string{
@@ -244,74 +245,79 @@ func TestGenerateVirtualMachineGroupAnnotations(t *testing.T) {
 		},
 		{
 			name: "Skip if Member Kind is not VirtualMachine",
-			vmg: &vmoprv1.VirtualMachineGroup{
-				ObjectMeta: baseVMG.ObjectMeta,
-				Status: vmoprv1.VirtualMachineGroupStatus{
+			vmg: func() *vmoprv1.VirtualMachineGroup {
+				v := baseVMG.DeepCopy()
+				v.Status = vmoprv1.VirtualMachineGroupStatus{
 					Members: []vmoprv1.VirtualMachineGroupMemberStatus{
 						newVMGMemberStatus("VMG-1", "VirtualMachineGroup", true, true, "zone-x"),
 					},
-				},
-			},
+				}
+				return v
+			}(),
 			machineDeployments:   []string{},
 			initialClientObjects: []client.Object{},
 			expectedAnnotations:  map[string]string{},
 			wantErr:              false,
 		},
 		{
 			name: "Skip if VSphereMachine Missing MachineDeployment Label",
-			vmg: &vmoprv1.VirtualMachineGroup{
-				ObjectMeta: baseVMG.ObjectMeta,
-				Status: vmoprv1.VirtualMachineGroupStatus{
+			vmg: func() *vmoprv1.VirtualMachineGroup {
+				v := baseVMG.DeepCopy()
+				v.Status = vmoprv1.VirtualMachineGroupStatus{
 					Members: []vmoprv1.VirtualMachineGroupMemberStatus{
 						newVMGMemberStatus("vsm-nolabel", "VirtualMachine", true, true, zoneA),
 					},
-				},
-			},
+				}
+				return v
+			}(),
 			machineDeployments:   []string{mdName1},
 			initialClientObjects: []client.Object{vsmMissingLabel},
 			expectedAnnotations:  map[string]string{},
 			wantErr:              false,
 		},
 		{
 			name: "Skip if VSphereMachine is Not Found in API",
-			vmg: &vmoprv1.VirtualMachineGroup{
-				ObjectMeta: baseVMG.ObjectMeta,
-				Status: vmoprv1.VirtualMachineGroupStatus{
+			vmg: func() *vmoprv1.VirtualMachineGroup {
+				v := baseVMG.DeepCopy()
+				v.Status = vmoprv1.VirtualMachineGroupStatus{
 					Members: []vmoprv1.VirtualMachineGroupMemberStatus{
 						newVMGMemberStatus("non-existent-vm", "VirtualMachine", true, true, zoneA),
 					},
-				},
-			},
+				}
+				return v
+			}(),
 			machineDeployments:   []string{mdName1},
 			initialClientObjects: []client.Object{vsm1},
 			expectedAnnotations:  map[string]string{},
 			wantErr:              false,
 		},
 		{
 			name: "Skip if placement is nil",
-			vmg: &vmoprv1.VirtualMachineGroup{
-				ObjectMeta: baseVMG.ObjectMeta,
-				Status: vmoprv1.VirtualMachineGroupStatus{
+			vmg: func() *vmoprv1.VirtualMachineGroup {
+				v := baseVMG.DeepCopy()
+				v.Status = vmoprv1.VirtualMachineGroupStatus{
 					Members: []vmoprv1.VirtualMachineGroupMemberStatus{
 						newVMGMemberStatus(vsmName1, "VirtualMachine", true, false, zoneA),
 					},
-				},
-			},
+				}
+				return v
+			}(),
 			machineDeployments:   []string{mdName1},
 			initialClientObjects: []client.Object{vsm1},
 			expectedAnnotations:  map[string]string{},
 			wantErr:              false,
 		},
 		{
 			name: "Skip if Zone is empty string",
-			vmg: &vmoprv1.VirtualMachineGroup{
-				ObjectMeta: baseVMG.ObjectMeta,
-				Status: vmoprv1.VirtualMachineGroupStatus{
+			vmg: func() *vmoprv1.VirtualMachineGroup {
+				v := baseVMG.DeepCopy()
+				v.Status = vmoprv1.VirtualMachineGroupStatus{
 					Members: []vmoprv1.VirtualMachineGroupMemberStatus{
 						newVMGMemberStatus(vsmName1, "VirtualMachine", true, true, ""),
 					},
-				},
-			},
+				}
+				return v
+			}(),
 			machineDeployments:   []string{mdName1},
 			initialClientObjects: []client.Object{vsm1},
 			expectedAnnotations:  map[string]string{},