Skip to content

Commit 5db07e5

Browse files
authored
Merge pull request #5972 from willie-yao/fix-dalec-spec
Fix issue with revision substitution in dalec test template
2 parents b69672c + de030f4 commit 5db07e5

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

templates/test/ci/cluster-template-prow-dalec-custom-builds.yaml

Lines changed: 6 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/test/ci/prow-dalec-custom-builds/patches/azl3-machine-deployment.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,8 @@ spec:
105105
106106
for BINARY in "$${BINARIES[@]}"; do
107107
echo "* downloading and extracting binary: $${BINARY} $${VERSION}"
108-
REVISION=$${$${BINARY^^}_REVISION}
108+
BINARY_VAR="$${BINARY^^}_REVISION"
109+
REVISION=$${!BINARY_VAR}
109110
RPM_FILE="/tmp/$${BINARY}-$${VERSION}-$${REVISION}.$${OS_VERSION}.$${ARCH}.rpm"
110111
RPM_URL="$${BASE_URL}/$${BINARY}/$${VERSION}/$${OS_VERSION}/$${ARCH}/$${BINARY}-$${VERSION}-$${REVISION}.$${OS_VERSION}.$${ARCH}.rpm"
111112

templates/test/ci/prow-dalec-custom-builds/patches/control-plane-custom-builds.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
OS_VERSION="ubuntu24.04"
1616
ARCH="amd64"
1717
for BINARY in "$${BINARIES[@]}"; do
18-
DEB_VERSION=$${$${BINARY^^}_REVISION}
18+
BINARY_VAR="$${BINARY^^}_REVISION"
19+
DEB_VERSION=$${!BINARY_VAR}
1920
echo "* downloading and extracting binary: $${BINARY} $${VERSION} with deb version $${DEB_VERSION}"
2021
DEB_FILE="/tmp/$${BINARY}_$${VERSION}-$${DEB_VERSION}_$${ARCH}.deb"
2122
DEB_URL="$${BASE_URL}/$${BINARY}/$${VERSION}/$${OS_VERSION}/$${ARCH}/$${BINARY}_$${VERSION}-$${DEB_VERSION}_$${ARCH}.deb"

templates/test/ci/prow-dalec-custom-builds/patches/kubeadm-bootstrap-custom-builds.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
OS_VERSION="ubuntu24.04"
1616
ARCH="amd64"
1717
for BINARY in "$${BINARIES[@]}"; do
18-
DEB_VERSION=$${$${BINARY^^}_REVISION}
18+
BINARY_VAR="$${BINARY^^}_REVISION"
19+
DEB_VERSION=$${!BINARY_VAR}
1920
echo "* downloading and extracting binary: $${BINARY} $${VERSION} with deb version $${DEB_VERSION}"
2021
DEB_FILE="/tmp/$${BINARY}_$${VERSION}-$${DEB_VERSION}_$${ARCH}.deb"
2122
DEB_URL="$${BASE_URL}/$${BINARY}/$${VERSION}/$${OS_VERSION}/$${ARCH}/$${BINARY}_$${VERSION}-$${DEB_VERSION}_$${ARCH}.deb"

0 commit comments

Comments
 (0)