set go to 1.23 in azclient and 1.24 in cloud provider (#8376)

Signed-off-by: Fan Shang Xiang <[email protected]>

Author: MartinForReal

.github/workflows/codeql-analysis.yml

@@ -66,8 +66,10 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
       with:
-        go-version: '>=1.20'
+        go-version-file: 'go.mod'
         check-latest: true
+        cache-dependency-path: |
+          go.sum
       id: go
 
     # Initializes the CodeQL tools for scanning.

.github/workflows/codeql-azclient.yml

@@ -17,13 +17,11 @@ on:
     branches: [ master ]
     paths:
       - 'pkg/azclient/**'
-      - '!pkg/azclient/trace/**'
   pull_request:
     # The branches below must be a subset of the branches above
     branches: [ master ]
     paths:
       - 'pkg/azclient/**'
-      - '!pkg/azclient/trace/**'
 permissions:
   contents: read
 
@@ -58,8 +56,6 @@ jobs:
         check-latest: true
         cache-dependency-path: |
           pkg/azclient/go.sum
-          pkg/azclient/client-gen/go.sum
-          pkg/azclient/configloader/go.sum
       id: go
 
     # Initializes the CodeQL tools for scanning.
@@ -77,7 +73,7 @@ jobs:
     - name: Autobuild
       run: |
         cd pkg/azclient
-        make generate
+        make generate test
         echo "fail if files changed"
         git add . && git diff --quiet && git diff --cached --quiet 
     - name: Perform CodeQL Analysis

.github/workflows/lint-azclient.yaml

@@ -0,0 +1,45 @@
+name: Code Lint - azclient
+
+on: 
+  push:
+    branches: [ master, 'release-**' ]
+    paths:
+      - 'pkg/azclient/**'
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ master, 'release-**' ]
+    paths:
+      - 'pkg/azclient/**'
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  Lint:
+    permissions:
+      contents: read  # for actions/checkout to fetch code
+      pull-requests: read  # for golangci/golangci-lint-action to fetch pull requests
+      checks: write
+    runs-on: ubuntu-latest
+    steps:
+      - name: Harden Runner
+        uses: step-security/harden-runner@4d991eb9b905ef189e4c376166672c3f2f230481 # v2.11.0
+        with:
+          egress-policy: audit
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - name: Setup Golang
+        uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
+        with:
+          go-version-file: 'pkg/azclient/go.mod'
+          check-latest: true
+          cache-dependency-path: |
+            pkg/azclient/go.sum
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@2226d7cb06a077cd73e56eedd38eecad18e5d837 # v6.5.0
+        with:
+          # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
+          version: v1.64
+          args: -v
+          verify: true

.github/workflows/lint.yaml

@@ -3,9 +3,25 @@ name: Code Lint
 on: 
   push:
     branches: [ master, 'release-**' ]
+    paths:
+      - 'pkg/**.go'
+      - 'cmd/**.go'
+      - 'tests/**.go'
+      - 'go.*'
+      - 'hack/verify-updates.sh'
+      - '!vendor/**'
+      - '!pkg/azclient/**'
   pull_request:
     # The branches below must be a subset of the branches above
     branches: [ master, 'release-**' ]
+    paths:
+      - 'pkg/**.go'
+      - 'cmd/**.go'
+      - 'tests/**.go'
+      - 'go.*'
+      - 'hack/verify-updates.sh'
+      - '!vendor/**'
+      - '!pkg/azclient/**'
   workflow_dispatch:
 
 permissions:
@@ -28,8 +44,10 @@ jobs:
       - name: Setup Golang
         uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
         with:
-          go-version: '1.23'
+          go-version-file: 'go.mod'
           check-latest: true
+          cache-dependency-path: |
+            go.sum
       - name: golangci-lint
         uses: golangci/golangci-lint-action@2226d7cb06a077cd73e56eedd38eecad18e5d837 # v6.5.0
         with:

.github/workflows/release.yaml

@@ -68,8 +68,10 @@ jobs:
       - name: Setup Golang
         uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
         with:
-          go-version-file: go.mod
-          cache: true
+          go-version-file: 'go.mod'
+          check-latest: true
+          cache-dependency-path: |
+            go.sum
       - name: Build binary for linux
         if: matrix.os == 'linux'
         run: |
@@ -120,7 +122,10 @@ jobs:
       - name: Setup Golang
         uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
         with:
-          go-version-file: go.mod
+          go-version-file: 'go.mod'
+          check-latest: true
+          cache-dependency-path: |
+            go.sum
       - name: Build binary for linux
         if: matrix.os == 'linux'
         run: |

.github/workflows/trivy.yaml

@@ -44,8 +44,10 @@ jobs:
       - name: Set up Go 1.x
         uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
         with:
-          go-version: '>=1.20'
+          go-version-file: 'go.mod'
           check-latest: true
+          cache-dependency-path: |
+            go.sum
         id: go
       - name: Build images
         run: |

.github/workflows/update-vendor-license.yml

@@ -46,8 +46,10 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
       with:
-        go-version: '>=1.20'
+        go-version-file: 'go.mod'
         check-latest: true
+        cache-dependency-path: |
+          go.sum
       id: go
 
     - name: Autobuild

Dockerfile

@@ -14,7 +14,7 @@
 
 # syntax=docker/dockerfile:1
 
-FROM --platform=linux/amd64 mcr.microsoft.com/oss/go/microsoft/golang:1.23.6-bookworm@sha256:02a6172539bd60b8a1f555301a21a2e248b3d957c9a46bbe18509edf2db47d13 AS builder
+FROM --platform=linux/amd64 mcr.microsoft.com/oss/go/microsoft/golang:1.24.0-bookworm@sha256:612a91edb4ff7d4c0e5a51daa3e9f15ac6c16c255a5f7a84d08348b7b30d6f69 AS builder
 
 ARG ENABLE_GIT_COMMAND=true
 ARG ARCH=amd64

cloud-node-manager.Dockerfile

@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM --platform=linux/amd64 mcr.microsoft.com/oss/go/microsoft/golang:1.23.6-bookworm@sha256:02a6172539bd60b8a1f555301a21a2e248b3d957c9a46bbe18509edf2db47d13 AS builder
+FROM --platform=linux/amd64 mcr.microsoft.com/oss/go/microsoft/golang:1.24-bookworm@sha256:612a91edb4ff7d4c0e5a51daa3e9f15ac6c16c255a5f7a84d08348b7b30d6f69 AS builder
 
 ARG ENABLE_GIT_COMMAND=true
 ARG ARCH=amd64

cloudbuild.yaml

@@ -8,7 +8,7 @@ options:
   substitution_option: ALLOW_LOOSE
 steps:
   # gcb-docker-gcloud is published at https://testgrid.k8s.io/sig-testing-image-pushes#gcb-docker-gcloud
-  - name: "gcr.io/k8s-staging-test-infra/gcb-docker-gcloud@sha256:4e830b673791d5595719bc6c4ca62dce3746b4e20d749e45004254bc6ef0a140" # v20250116-2a05ea7e3d
+  - name: "gcr.io/k8s-staging-test-infra/gcb-docker-gcloud"
     entrypoint: make
     env:
       - TAG=${_GIT_TAG}