Skip to content

Commit cfb623b

Browse files
authored
chore(acr): remove used login server (#9468)
Signed-off-by: Billy Zha <[email protected]>
1 parent 4e98349 commit cfb623b

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

pkg/credentialprovider/azure_acr_helper.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ func receiveChallengeFromLoginServer(serverAddress, scheme string) (*authDirecti
141141
}
142142

143143
func performTokenExchange(
144-
_ string,
145144
directive *authDirective,
146145
tenant string,
147146
accessToken string) (string, error) {

pkg/credentialprovider/azure_acr_helper_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ func TestPerformTokenExchange(t *testing.T) {
136136
}))
137137
defer server.Close()
138138

139-
got, err := performTokenExchange(server.URL, &authDirective{realm: server.URL}, "tenant", "token")
139+
got, err := performTokenExchange(&authDirective{realm: server.URL}, "tenant", "token")
140140
assert.Equal(t, tt.want, got, tt.name)
141141
if tt.wantErr != nil {
142142
assert.Contains(t, err.Error(), tt.wantErr.Error(), tt.name)

pkg/credentialprovider/azure_credentials.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,8 +211,7 @@ func (a *acrProvider) getFromACR(ctx context.Context, loginServer string) (strin
211211
}
212212

213213
klog.V(4).Infof("exchanging an acr refresh_token")
214-
registryRefreshToken, err := performTokenExchange(
215-
loginServer, directive, a.config.TenantID, armAccessToken.Token)
214+
registryRefreshToken, err := performTokenExchange(directive, a.config.TenantID, armAccessToken.Token)
216215
if err != nil {
217216
klog.Errorf("failed to perform token exchange: %s", err)
218217
return "", "", err

0 commit comments

Comments
 (0)