checkpoint: Enhance service gateway existence check and configuration validation

Author: georgeedward2000

pkg/provider/azure_loadbalancer_repo.go

@@ -148,7 +148,7 @@ func (az *Cloud) ListManagedLBs(ctx context.Context, service *v1.Service, nodes
 // CreateOrUpdateLB invokes az.NetworkClientFactory.GetLoadBalancerClient().CreateOrUpdate with exponential backoff retry
 func (az *Cloud) CreateOrUpdateLB(ctx context.Context, service *v1.Service, lb armnetwork.LoadBalancer) error {
 	klog.Infof("EDWARD: CreateOrUpdateLB: creating default load balancer for Service Gateway: ")
-	logObject(lb)
+	// logObject(lb)
 	lb = cleanupSubnetInFrontendIPConfigurations(&lb)
 
 	rgName := az.getLoadBalancerResourceGroup()

pkg/provider/azure_servicegateway_difftracker_init.go

@@ -98,7 +98,7 @@ func (az *Cloud) initializeDiffTracker() error {
 		}
 	}
 	klog.Infof("initializeDiffTracker: nodeNameToIPMap: ")
-	logObject(nodeNameToIPMap)
+	//logObject(nodeNameToIPMap)
 
 	// 1. Fetch all services and update difftracker.K8sResources.Services
 	services, err := az.KubeClient.CoreV1().Services(v1.NamespaceAll).List(ctx, metav1.ListOptions{})
@@ -249,7 +249,7 @@ func (az *Cloud) initializeDiffTracker() error {
 
 	locationsDTO, err := az.GetAddressLocations(ctx, az.ServiceGatewayResourceName)
 	klog.Infof("initializeDiffTracker: fetched %d locations from ServiceGateway API", len(locationsDTO))
-	logObject(locationsDTO)
+	//logObject(locationsDTO)
 	if err != nil {
 		return fmt.Errorf("initializeDiffTracker: failed to get locations from ServiceGateway API: %w", err)
 	}
@@ -294,10 +294,10 @@ func (az *Cloud) initializeDiffTracker() error {
 	az.diffTracker = difftracker.InitializeDiffTracker(k8s, nrp)
 	az.diffTracker.LocalServiceNameToNRPServiceMap = syncMapFromMap(localServiceNameToNRPServiceMap)
 	klog.Infof("initializeDiffTracker: initialized diff tracker localServiceNameToNRPServiceMap with %d entries", localServiceNameToNRPServiceMap)
-	logObject(localServiceNameToNRPServiceMap)
+	//logObject(localServiceNameToNRPServiceMap)
 	logSyncStringIntMap("initializeDiffTracker: LocalServiceNameToNRPServiceMap", &az.diffTracker.LocalServiceNameToNRPServiceMap)
 	klog.Infof("initializeDiffTracker: initialized diff tracker")
-	logObject(az.diffTracker)
+	//logObject(az.diffTracker)
 	// 6. Fetch LoadBalancers from NRP
 	lbclient := az.NetworkClientFactory.GetLoadBalancerClient()
 	lbs, err := lbclient.List(ctx, az.ResourceGroup)

pkg/provider/azure_servicegateway_location_service_updater.go

@@ -49,18 +49,18 @@ func (az *Cloud) TriggerLocationAndNRPServiceBatchUpdate() {
 func (updater *locationAndNRPServiceBatchUpdater) process(ctx context.Context) {
 	klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process BEGIN: processing batch update\n")
 	klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process BEGIN: difftracker:\n")
-	logDiffTracker(updater.az.diffTracker)
+	// logDiffTracker(updater.az.diffTracker)
 	// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process BEGIN: subscription ID: %s\n", updater.az.SubscriptionID)
 	// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process BEGIN: resource group: %s\n", updater.az.ResourceGroup)
 	// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process BEGIN: location and NRP service batch updater started\n")
 
 	serviceLoadBalancerList := updater.az.diffTracker.GetSyncLoadBalancerServices()
 	serviceNATGatewayList := updater.az.diffTracker.GetSyncNRPNATGateways()
 
-	klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: serviceLoadBalancerList:\n")
-	logObject(serviceLoadBalancerList)
-	klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: serviceNATGatewayList:\n")
-	logObject(serviceNATGatewayList)
+	// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: serviceLoadBalancerList:\n")
+	//logObject(serviceLoadBalancerList)
+	// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: serviceNATGatewayList:\n")
+	//logObject(serviceNATGatewayList)
 	// Add services
 	if serviceLoadBalancerList.Additions.Len() > 0 || serviceNATGatewayList.Additions.Len() > 0 {
 		createServicesRequestDTO := difftracker.MapLoadBalancerAndNATGatewayUpdatesToServicesDataDTO(
@@ -74,8 +74,8 @@ func (updater *locationAndNRPServiceBatchUpdater) process(ctx context.Context) {
 			},
 			updater.az.SubscriptionID,
 			updater.az.ResourceGroup)
-		klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: createServicesRequestDTO:\n")
-		logObject(createServicesRequestDTO)
+		// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: createServicesRequestDTO:\n")
+		//logObject(createServicesRequestDTO)
 		// createServicesResponseDTO := NRPAPIClientUpdateNRPServices(ctx, createServicesRequestDTO, updater.az.SubscriptionID, updater.az.ResourceGroup)
 		// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: createServicesResponseDTO:\n")
 		err := updater.az.UpdateNRPSGWServices(ctx, updater.az.ServiceGatewayResourceName, createServicesRequestDTO)
@@ -151,8 +151,8 @@ func (updater *locationAndNRPServiceBatchUpdater) process(ctx context.Context) {
 
 	// Update all locations and addresses
 	locationData := updater.az.diffTracker.GetSyncLocationsAddresses()
-	klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: locationData:\n")
-	logObject(locationData)
+	// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: locationData:\n")
+	// logObject(locationData)
 	if len(locationData.Locations) > 0 {
 		locationDataRequestDTO := difftracker.MapLocationDataToDTO(locationData)
 		// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process: locationDataRequestDTO:\n")
@@ -211,7 +211,7 @@ func (updater *locationAndNRPServiceBatchUpdater) process(ctx context.Context) {
 
 	// klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process END: processing batch update")
 	klog.Infof("CLB-ENECHITOAIA-locationAndNRPServiceBatchUpdater.process END: difftracker:")
-	logDiffTracker(updater.az.diffTracker)
+	// logDiffTracker(updater.az.diffTracker)
 }
 
 func logDiffTracker(dt interface{}) {