set apiVersion for mooncake cloud

Signed-off-by: MartinForReal <[email protected]>

Author: MartinForReal

.github/workflows/codeql-azclient.yml

@@ -0,0 +1,90 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL-azclient"
+
+on:
+  workflow_dispatch:
+  push:
+    branches: [ master ]
+    paths:
+      - 'pkg/azclient/**'
+      - '!pkg/azclient/trace/**'
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ master ]
+    paths:
+      - 'pkg/azclient/**'
+      - '!pkg/azclient/trace/**'
+permissions:
+  contents: read
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'go' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+        # Learn more about CodeQL language support at https://git.io/codeql-language-support
+
+    steps:
+    - name: Harden Runner
+      uses: step-security/harden-runner@4d991eb9b905ef189e4c376166672c3f2f230481 # v2.11.0
+      with:
+        egress-policy: audit
+
+    - name: Checkout repository
+      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+    - name: Set up Go 1.x
+      uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
+      with:
+        go-version: '>=1.20'
+        check-latest: true
+        cache-dependency-path: |
+          pkg/azclient/go.sum
+          pkg/azclient/client-gen/go.sum
+          pkg/azclient/configloader/go.sum
+      id: go
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@b56ba49b26e50535fa1e7f7db0f4f7b4bf65d80d # v3.28.10
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+        # queries: ./path/to/local/query, your-org/your-repo/queries@main
+
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    - name: Autobuild
+      run: |
+        make all
+        go test -covermode=count -coverprofile=profile.cov.tmp ./pkg/azclient/...
+        grep -v mock profile.cov.tmp > profile.cov
+
+    - name: Coveralls
+      uses: coverallsapp/github-action@648a8eb78e6d50909eff900e4ec85cab4524a45b # v2.3.6
+      with:
+        file: profile.cov
+        format: golang
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@b56ba49b26e50535fa1e7f7db0f4f7b4bf65d80d # v3.28.10

pkg/azclient/.golangci.yml

@@ -0,0 +1,42 @@
+run:
+  timeout: 30m
+  tests: true
+linters:
+  disable-all: true
+  enable:
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused
+    - goconst
+    - goimports
+    - revive
+    - gosec
+    - misspell
+    - nakedret
+    - typecheck
+    - unconvert
+    - asasalint
+    - asciicheck
+    - bidichk
+    - errorlint
+    - loggercheck
+  fast: false
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
+linters-settings:
+  staticcheck:
+    checks: ["all", "-SA1019"]
+  gosec:
+    excludes:
+      - G114
+      - G115
+  goimports:
+    local-prefixes: sigs.k8s.io/cloud-provider-azure/pkg/azclient
+  goconst:
+    min-occurrences: 10
+
+  

pkg/azclient/Makefile

@@ -70,6 +70,7 @@ build: ## Build manager binary.
 .PHONY: test
 test: ## Run tests.
 	go test -v ./...
+	echo "Mooncake test ***************************************"; AZURE_CLOUD=AZURECHINACLOUD go test -v ./...
 
 .PHONY: generate
 generate: install-dependencies build generatecode generateimpl generateclientfactory generatemock fmt vet-all test

pkg/azclient/accountclient/accountclient_suite_test.go

@@ -25,7 +25,7 @@ import (
 	"sigs.k8s.io/cloud-provider-azure/pkg/azclient/utils"
 )
 
-// +azure:client:verbs=listbyrg,resource=Account,packageName=github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage,packageAlias=armstorage,clientName=AccountsClient,expand=true,crossSubFactory=true,rateLimitKey=storageAccountRateLimit,azureStackCloudAPIVersion="2018-02-01"
+// +azure:client:verbs=listbyrg,resource=Account,packageName=github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage,packageAlias=armstorage,clientName=AccountsClient,expand=true,crossSubFactory=true,rateLimitKey=storageAccountRateLimit,azureStackCloudAPIVersion="2018-02-01",mooncakeApiVersion="2023-05-01"
 type Interface interface {
 	utils.ListFunc[armstorage.Account]
 	Create(ctx context.Context, resourceGroupName string, accountName string, resource *armstorage.AccountCreateParameters) (*armstorage.Account, error)