Skip to content

Commit 3935a17

Browse files
authored
Merge pull request #1351 from torredil/release-1.11
Explicitly pass VERSION as a build-arg
2 parents 29430e5 + 2cf8986 commit 3935a17

File tree

4 files changed

+4
-1
lines changed

4 files changed

+4
-1
lines changed

.github/workflows/publish-ecr.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ jobs:
3636
run: |
3737
echo "REGISTRY=${REGISTRY}" >> $GITHUB_ENV
3838
echo "TAG=${GITHUB_REF_NAME}" >> $GITHUB_ENV
39+
echo "VERSION=${GITHUB_REF_NAME}" >> $GITHUB_ENV
3940
4041
- name: Build, tag, and push manifest to Amazon ECR
4142
run: make -j `nproc` all-push

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ jobs:
2222
2323
## CHANGELOG
2424
See [CHANGELOG](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md) for full list of changes
25-
draft: false
25+
draft: true
2626
prerelease: false

Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ RUN go mod download
2323
COPY . .
2424
ARG TARGETOS
2525
ARG TARGETARCH
26+
ARG VERSION
2627
RUN OS=$TARGETOS ARCH=$TARGETARCH make $TARGETOS/$TARGETARCH
2728

2829
FROM public.ecr.aws/eks-distro-build-tooling/eks-distro-minimal-base-csi-ebs:latest.2 AS linux-amazon

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ image: .image-$(TAG)-$(OS)-$(ARCH)-$(OSVERSION)
102102
--output=type=$(OUTPUT_TYPE) \
103103
-t=$(IMAGE):$(TAG)-$(OS)-$(ARCH)-$(OSVERSION) \
104104
--build-arg=GOPROXY=$(GOPROXY) \
105+
--build-arg=VERSION=$(VERSION) \
105106
.
106107
touch $@
107108

0 commit comments

Comments
 (0)