Python runtime sandbox e2e test #161

shrutiyam-glitch · 2025-11-14T18:34:05Z

Adds e2e test for the python runtime sandbox example.
Test file: test/e2e/pythonruntime_test.go
Scenarios covered -

applies sandbox(python-runtime-sandbox) manifest directly
Applies sandbox template and sandbox claim and creates a python runtime sandbox
Applies sandbox warmpool and creates a python runtime

Test cases -

Tests port forwarding to the sandbox - general health check
executes “hello world”

linux-foundation-easycla · 2025-11-14T18:34:12Z

The committers listed above are authorized under a signed CLA.

✅ login: shrutiyam-glitch / name: Author Name (f1be5f0)
✅ login: shrutiyam-glitch / name: Shrutiya (1cf306c, 59cbe6d, 92a38e0, c593dc1)

k8s-ci-robot · 2025-11-14T18:34:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shrutiyam-glitch
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2025-11-14T18:34:12Z

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	`59cbe6d`
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/6925ff180ba91a000931ab72

k8s-ci-robot · 2025-11-14T18:34:15Z

Welcome @shrutiyam-glitch!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-11-14T18:34:16Z

Hi @shrutiyam-glitch. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tomergee · 2025-11-17T18:37:07Z

Thank you @shrutiyam-glitch for the PR, can you also add a test for python-runtime using gVisor? It can be based on "e2e-pytest-template" by changing the runtime in the template. This depends on other open PRs for the test to check if it works (#150 and #159)

janetkuo · 2025-11-17T19:15:29Z

/ok-to-test

janetkuo · 2025-11-17T19:16:55Z

@shrutiyam-glitch please sign the CLA, ref #161 (comment)

tomergee · 2025-11-19T17:52:17Z

test/e2e/pythonruntime_test.go

+		}
+
+		portForwardCtx, portForwardCancel := context.WithCancel(ctx)
+		h.PortForward(portForwardCtx, podID, 8888, 8888)


Check if the runtime is set so runsc or kata-qemu and if so skip the port forwarding part. TODO - After the python e2e tests are merged test via gateway

igooch

Good work, left a new comments.

test/e2e/pythonruntime_test.go

igooch · 2025-11-21T18:33:33Z

test/e2e/pythonruntime_test.go

+	"sigs.k8s.io/agent-sandbox/test/e2e/framework"
+)
+
+const sandboxManifest = `


For a few manifests this is fine. If we have more than that you'll want to pull these out into separate .yaml files.

igooch · 2025-11-21T19:10:21Z

test/e2e/framework/client.go

 	cl.Helper()
 	// Static 30 second timeout, this can be adjusted if needed
-	timeoutCtx, cancel := context.WithTimeout(ctx, 30*time.Second)
+	timeoutCtx, cancel := context.WithTimeout(ctx, 60*time.Second)


We should update this from be configurable, and make the default timeout a constant defined at the top of the file. That way each tests can have an appropriate timeout. So something like:

var cancel context.CancelFunc if _, ok := ctx.Deadline(); !ok { ctx, cancel = context.WithTimeout(ctx, DefaultTimeout) defer cancel() }

And then tests either use the default timeout, or pass a context with a longer timeout:

// Uses default timeout cl.WaitForObject(ctx, sandbox, predicates.ReadyConditionIsTrue)

// Custom timeout case for slower operations like warmPool timeoutCtx, cancel := context.WithTimeout(ctx, 1*time.Minute) defer cancel() cl.WaitForObject(timeoutCtx, warmPool, predicates.ReadyConditionIsTrue)

igooch · 2025-11-22T01:16:03Z

test/e2e/framework/client.go

+	for {
+		select {


The outer for loop + select with cases can be replaced by a wait from the package k8s.io/apimachinery/pkg/util/wait similar to:

return wait.PollUntilContextTimeout(ctx, 2*time.Second, 1*time.Minute, true, func(ctx context.Context) (bool, error) {

test/e2e/pythonruntime_test.go

sdowell · 2025-12-01T18:55:21Z

test/e2e/pythonruntime_test.go

+	ctx, cancel := context.WithCancel(ctx)
+	defer cancel()
+
+	log := klog.FromContext(ctx)


Use the testing.T logger and context (see #106 as an example)

k8s-ci-robot · 2025-12-02T06:26:32Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vicentefb · 2025-12-02T07:59:38Z

dev/tools/test-e2e



 if __name__ == "__main__":
-    sys.exit(main())


This change isn't needed

k8s-ci-robot requested review from janetkuo and soltysh November 14, 2025 18:34

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 14, 2025

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 14, 2025

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 14, 2025

shrutiyam-glitch marked this pull request as draft November 14, 2025 18:34

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2025

Python runtime sandbox and python sdk e2e test

f1be5f0

shrutiyam-glitch force-pushed the python-runtime-e2e-test branch from 4806373 to f1be5f0 Compare November 17, 2025 19:46

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 17, 2025

Remove python sdk test files

c593dc1

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2025

tomergee reviewed Nov 19, 2025

View reviewed changes

shrutiyam-glitch marked this pull request as ready for review November 19, 2025 18:56

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025

fix lint

1cf306c

igooch reviewed Nov 22, 2025

View reviewed changes

Addressed comments

92a38e0

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2025

Updated variables and fixed test

59cbe6d

shrutiyam-glitch changed the title ~~Python runtime sandbox and Python sdk e2e test~~ Python runtime sandbox e2e test Nov 27, 2025

sdowell reviewed Dec 1, 2025

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025

vicentefb reviewed Dec 2, 2025

View reviewed changes

dev/tools/test-e2e

if __name__ == "__main__":

sys.exit(main())

Copy link

Contributor

vicentefb Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't needed

Python runtime sandbox e2e test #161

Are you sure you want to change the base?

Python runtime sandbox e2e test #161

Conversation

shrutiyam-glitch commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Nov 14, 2025

Uh oh!

netlify bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for agent-sandbox canceled.

Uh oh!

k8s-ci-robot commented Nov 14, 2025

Uh oh!

k8s-ci-robot commented Nov 14, 2025

Uh oh!

tomergee commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janetkuo commented Nov 17, 2025

Uh oh!

janetkuo commented Nov 17, 2025

Uh oh!

tomergee Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

igooch Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

igooch Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

igooch Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sdowell Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Dec 2, 2025

Uh oh!

vicentefb Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shrutiyam-glitch commented Nov 14, 2025 •

edited

Loading

linux-foundation-easycla bot commented Nov 14, 2025 •

edited

Loading

netlify bot commented Nov 14, 2025 •

edited

Loading

tomergee commented Nov 17, 2025 •

edited

Loading