test: minor refactor of TestRunChromeSandbox #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agent-sandbox canceled.
|
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdowell The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
This change includes some minor cleanup and refactor of the chrome sandbox test. - return error instead of calling Fatal in nested helper functions to help the control flow - use the testing logger so that logs are properly formatted - consolidate test utilities and remove unused functions
sdowell
force-pushed
the
test-chrome-sandbox
branch
from
90ca254 to
d100738
Compare
barney-s
reviewed
Oct 21, 2025
| { | ||
| Name: "chrome-sandbox", | ||
| // might be nice to remove the IMAGE_TAG env var so this is easier to run from IDE | ||
| Image: fmt.Sprintf("kind.local/chrome-sandbox:%s", os.Getenv("IMAGE_TAG")), |
Contributor
There was a problem hiding this comment.
can be done by adding a well known tag as part of build.
Contributor
Author
There was a problem hiding this comment.
Agreed that would make sense as an approach. I'd suggest we address it as a separate change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes some minor cleanup and refactor of the chrome sandbox test.