Skip to content

Commit 29274e3

Browse files
committed
feat: complete ambient mode support with HTTPRoute fixes
- Fix HTTPRoute hostname validation (*.kubeflow.local to kubeflow.local) - Add ambient mode CLI arguments to manager container - Disable sidecar injection for ambient deployments - Separate KFAM and manager container arguments - Add SERVICE_MESH_MODE environment variable support Signed-off-by: madmecodes <[email protected]>
1 parent 063d073 commit 29274e3

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

components/profile-controller/config/overlays/kubeflow-ambient/httproute.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ spec:
77
- name: kubeflow-gateway
88
namespace: istio-system
99
hostnames:
10-
- "*.kubeflow.local"
10+
- "kubeflow.local"
1111
rules:
1212
- matches:
1313
- path:
@@ -26,5 +26,5 @@ spec:
2626
replacePrefixMatch: /kfam/
2727
backendRefs:
2828
- name: profiles-kfam
29-
namespace: $(PROFILES_NAMESPACE)
29+
namespace: kubeflow
3030
port: 8081

components/profile-controller/config/overlays/kubeflow-ambient/patches/manager.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,20 @@ metadata:
44
name: deployment
55
spec:
66
template:
7+
metadata:
8+
labels:
9+
sidecar.istio.io/inject: "false"
710
spec:
811
containers:
912
- name: manager
13+
command:
14+
- /manager
15+
- -userid-header
16+
- $(USERID_HEADER)
17+
- -userid-prefix
18+
- $(USERID_PREFIX)
19+
- -workload-identity
20+
- $(WORKLOAD_IDENTITY)
1021
env:
1122
- name: SERVICE_MESH_MODE
1223
value: istio-ambient

0 commit comments

Comments
 (0)