Skip to content

Commit 31ebe73

Browse files
feat: add S390x support in affinity rule (#503)
Added s390x in node affinity rule as already work is going on to support s390x for tensorflow in runtime-adaptor --------- Signed-off-by: Modassar Rana <[email protected]>
1 parent 028f646 commit 31ebe73

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

controllers/modelmesh/runtime.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -341,17 +341,15 @@ func addDomainSocketMount(rts *kserveapi.ServingRuntimeSpec, c *corev1.Container
341341
func (m *Deployment) addPassThroughPodFieldsToDeployment(deployment *appsv1.Deployment) error {
342342
rts := m.SRSpec
343343
// these fields map directly to pod spec fields
344-
// supported architectures are "amd64" and "arm64", "ppc64le"
345-
// and "s390x" are not supported by tensorflow
346-
// (https://github.com/kserve/modelmesh-runtime-adapter/pull/38#discussion_r1156749259)
344+
// supported architectures are "amd64", "arm64" and "s390x"
347345
deployment.Spec.Template.Spec.NodeSelector = rts.NodeSelector
348346
deployment.Spec.Template.Spec.Tolerations = rts.Tolerations
349347
archNodeSelector := corev1.NodeSelectorTerm{
350348
MatchExpressions: []corev1.NodeSelectorRequirement{
351349
{
352350
Key: "kubernetes.io/arch",
353351
Operator: corev1.NodeSelectorOpIn,
354-
Values: []string{"amd64", "arm64"},
352+
Values: []string{"amd64", "arm64", "s390x"},
355353
},
356354
},
357355
}

controllers/testdata/servingruntime_controller.golden

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ spec:
3838
values:
3939
- amd64
4040
- arm64
41+
- s390x
4142
containers:
4243
- command:
4344
- /opt/app/mlserver-adapter
@@ -292,6 +293,7 @@ spec:
292293
values:
293294
- amd64
294295
- arm64
296+
- s390x
295297
containers:
296298
- command:
297299
- /opt/app/mlserver-adapter
@@ -542,6 +544,7 @@ spec:
542544
values:
543545
- amd64
544546
- arm64
547+
- s390x
545548
containers:
546549
- env:
547550
- name: REST_PROXY_LISTEN_PORT
@@ -814,6 +817,7 @@ spec:
814817
values:
815818
- amd64
816819
- arm64
820+
- s390x
817821
containers:
818822
- command:
819823
- /opt/app/mlserver-adapter
@@ -1061,6 +1065,7 @@ spec:
10611065
values:
10621066
- amd64
10631067
- arm64
1068+
- s390x
10641069
containers:
10651070
- command:
10661071
- /opt/app/ovms-adapter
@@ -1300,6 +1305,7 @@ spec:
13001305
values:
13011306
- amd64
13021307
- arm64
1308+
- s390x
13031309
containers:
13041310
- command:
13051311
- /opt/app/torchserve-adapter
@@ -1542,6 +1548,7 @@ spec:
15421548
values:
15431549
- amd64
15441550
- arm64
1551+
- s390x
15451552
containers:
15461553
- command:
15471554
- /opt/app/triton-adapter
@@ -1799,6 +1806,7 @@ spec:
17991806
values:
18001807
- amd64
18011808
- arm64
1809+
- s390x
18021810
containers:
18031811
- env:
18041812
- name: MODEL_DIRECTORY_PATH

0 commit comments

Comments
 (0)