Fix version warning showing for patch releases of latest supported Kubernetes #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 94.61% 94.63% +0.01%
==========================================
Files 29 33 +4
Lines 3141 5030 +1889
==========================================
+ Hits 2972 4760 +1788
- Misses 169 270 +101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobtomlinson
force-pushed
the
bug/micro-version-check
branch
from
f06fd17 to
a6f1e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in CI that the latest supported version of Kubernetes is
1.33, but we are showing the supported versions warning when testing against1.33.4.This PR drops the patch version when comparing because we support future patch versions.
xref #686 #668