1.34 Support

[Lillecarl]

Which project are you reporting a bug for?

kr8s

What happened?

It seems like it's time to trigger the update-kubernetes workflow manually! 1.34 has been out for two months and from what I can tell there's nothing blocking kr8s from supporting it 😄

Anything else?

No response

[jacobtomlinson]

The script runs nightly looking for new images but for some reason it's not picking up the latest version. Let me look into it.

[jacobtomlinson]

Also it's likely that kr8s will "just work" with 1.34, but it's always good to have it tested in CI to confirm.

[jacobtomlinson]

Looks like the EOL date for 1.34 isn't documented yet on endoflife.date which we use as our source of truth for supported versions. I've opened endoflife-date/endoflife.date#8813 to add them.

[Lillecarl]

@jacobtomlinson Thanks, I missed that it's parsing the EOL date.
#692 somehow missed 1.34.1 just now though.

I'm already using it on 1.34.1, I saw the runtime warning and thought "hmm this doesn't seem right" 😄

[jacobtomlinson]

The update script works like this:

• Get Kubernetes versions and EOL dates from endoflife.date
• Check against managed Kubernetes platforms EOL dates and extend if necessary (e.g if AWS EKS supports 1.34 for longer then so do we)
• Cross reference versions against kind container images on DockerHub. Use the latest patch version for each minor version.

It looks like there isn't a kindest/node:v1.34.1 yet, so it's using kindest/node:v1.34.0.

[Lillecarl]

@jacobtomlinson Thanks for explanation 😄
I can confirm the preferences key is unset on my 1.34.1 local dev machine and set on a 1.33.3 cluster.
I'm quite inexperienced with Python and the codebase yet but I imagine

    @property
    def preferences(self) -> list[dict]:
        return self._raw["preferences"]

Should be

    @property
    def preferences(self) -> list[dict]:
        return self._raw.get("preferences", {})

Which is similar to

    @property
    def extensions(self) -> list[dict]:
        return self._raw["extensions"] if "extensions" in self._raw else []

But using slightly more idiomatic Python(?)

[jacobtomlinson]

Yup thanks, I've already pushed similar fixes to #692, just waiting on CI.