test: refactor testdata to be generated #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@knqyf263 is this a PR you're open to merging? |
* Removed hand-maintained test data * Added support for test fixture generation * Added additional test cases for amazonlinux, oraclelinux, fedora38
micahhausler
force-pushed
the
master
branch
from
da541ed to
cee58d9
Compare
Owner
|
Yes, but I currently have less capacity to review the large PR due to family circumstances. |
Author
|
Would you like this broken into smaller PRs? |
Owner
|
It would be helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
This doesn't change the API, or any functionality, but makes it easier to add new fields and tests.
Previously, large Go structs were committed with test data. This change uses
rpm -qa --queryformatto dump RPM database information and stores it as a CSV. This will enable more easily supporting new fields by runninggo test ./... -update-testcases=truerather than having to hand-edit the test fixtures.Given CentOS is no longer maintained, I added a amazonlinux and oraclelinux, and included existing CentOS databases. I'd be happy to update this PR dropping CentOS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.