Skip to content

Commit 5d6fed2

Browse files
committed
Used the correct name for the revision
1 parent 0cb7ff8 commit 5d6fed2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/e2e/minscale_readiness_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ func TestMinScale(t *testing.T) {
8787

8888
t.Log("Waiting for new revision's container to become healthy with the minScale")
8989
if err := v1test.WaitForRevisionState(
90-
clients.ServingClient, newRevName, v1test.IsRevisionContainerHealthy, "ContainerIsHealthy",
90+
clients.ServingClient, revName, v1test.IsRevisionContainerHealthy, "ContainerIsHealthy",
9191
); err != nil {
92-
t.Fatalf("The container of the Revision %q did not become healthy: %v", newRevName, err)
92+
t.Fatalf("The container of the Revision %q did not become healthy: %v", revName, err)
9393
}
9494

9595
revision, err := clients.ServingClient.Revisions.Get(context.Background(), revName, metav1.GetOptions{})
@@ -117,7 +117,7 @@ func TestMinScale(t *testing.T) {
117117
t.Fatalf("The revision %q observed scale %d < %d after becoming ready", revName, lr, minScale)
118118
}
119119

120-
revision, err := clients.ServingClient.Revisions.Get(context.Background(), revName, metav1.GetOptions{})
120+
revision, err = clients.ServingClient.Revisions.Get(context.Background(), revName, metav1.GetOptions{})
121121
if err != nil {
122122
t.Fatalf("An error occurred getting revision %v, %v", revName, err)
123123
}
@@ -140,9 +140,9 @@ func TestMinScale(t *testing.T) {
140140
t.Fatalf("The container of the Revision %q did not become healthy: %v", newRevName, err)
141141
}
142142

143-
revision, err := clients.ServingClient.Revisions.Get(context.Background(), revName, metav1.GetOptions{})
143+
revision, err = clients.ServingClient.Revisions.Get(context.Background(), newRevName, metav1.GetOptions{})
144144
if err != nil {
145-
t.Fatalf("An error occurred getting revision %v, %v", revName, err)
145+
t.Fatalf("An error occurred getting revision %v, %v", newRevName, err)
146146
}
147147
if replicas := *revision.Status.ActualReplicas; replicas < minScale {
148148
t.Fatalf("Container is indicated as healthy. Expected actual replicas for revision %v to be %v but got %v", revision.Name, minScale, replicas)

0 commit comments

Comments
 (0)