Skip to content

Algorithm that notifies users that a new GitHub update of Wikivoyage is available thinks 3.3.6 > 3.3.10 #631

@Jaifroid

Description

@Jaifroid

This means users will be incorrectly notified that there is an update (fortunately it's a silent but quite visible notification at the top of Configuration) that there is an "update" version 3.3.6, when in fact that is the previous version.

Clearly it is doing an arithmetic "greater than" instead of a semantic "greater than". Grrr.

I can probably fix this by deleting or unpublishing (for now) v3.3.6, as I can't now update the code of 3.3.10 (which is released).

Either I avoid releasing versions with minorVersion > 9, or else I fix the algorithm to use a semantic comparison (I'm sure I have a bit of code somewhere in the app that has the required logic already, it's just not in the Electron update part). A fix would be better, if that code is under my control (I believe it is).

Metadata

Metadata

Assignees

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions