Allow to build with packaged version of qtsingleapplication

[xvitaly]

Bundling is strictly forbidden in lots of GNU/Linux distributions. Please add ability to build with packaged version of qtsingleapplication.

[xvitaly]

Regression introduced in #424.

[xvitaly]

Fixed on our side by adding CONFIG+=qtsingleapplication to qmake-qt5.

[kelson42]

@xvitaly @mgautierfr I guess if the ticket is closed there is nothing to do on our end. I don't really understand the ticket.

[xvitaly]

I guess if the ticket is closed there is nothing to do on our end. I don't really understand the ticket.

I'm Kiwix Desktop Fedora GNU/Linux package maintainer. On Fedora we cannot use bundled dependencies, that's why we must unbundle all of them.

I fixed this issue on our side by removing the subprojects/qtsingleapplication directory and passing the CONFIG+=qtsingleapplication parameter to qmake-qt5 build tool.

[kelson42]

@xvitaly Thank you. I reopen the ticket because I don't understand why we don't do that upstream!

[xvitaly]

Thank you. I reopen the ticket because I don't understand why we don't do that upstream!

We also need to patch .pro file to remove /static option and remove git calls:

sed -e "/static {/,+2d" -e "/git describe/c\DEFINES += GIT_VERSION='%{version}'" -e "s/shell date/shell date +\%G-\%m-\%d/g" -i %{name}.pro

I would appreciate if it can be fixed in upstream.

[kelson42]

@xvitaly We will have a look, the ideal solution would be to build the Fedora packages within our CI so we can:

• Provide cutting-edge/testing RPM packges
• Secure upstream (at the source) that we won't have problems later.

This is an approach we are following for Deb packages (Debian/Ubuntu) and that I would be happy to see as well with Fedroa RPMs.

[xvitaly]

We will have a look, the ideal solution would be to build the Fedora packages within our CI so we can:

Fedora already has Kiwix Desktop (and kiwix-lib, kiwix-tools, libzim) in the official repositories.

This is an approach we are following for Deb packages (Debian/Ubuntu) and that I would be happy to see as well with Fedroa RPMs.

If you want to build Fedora packages for testing purposes on CI, feel free to take SPECs from Fedora:

• kiwix-desktop;
• zimlib;
• kiwix-lib;
• kiwix-tools.

If you have any question about Fedora packaging, I can help with this.

[legoktm]

Unfortunately Debian doesn't have qtsingleapplication packaged yet (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641812), so we would prefer to have it bundled along for now if that's alright...

[kelson42]

@legoktm Good to me.