null in body params is not the same as undef

[bensinober]

Thanks for this great and simple descriptive API!

I am thinking that the following code:

Raisin/lib/Raisin/Request.pm

Lines 25 to 37 in 7e460ee

	foreach my $p (@$declared) {
	my $name = $p->name;
	my $value = $params{$name};
	if (not $p->validate(\$value)) {
	$p->required ? return : next;
	}
	$value //= $p->default if defined $p->default;
	next if not defined($value);
	$self->{'raisin.declared_params'}{$name} = $value;
	}

will filter out also defined null values in JSON body, which makes it difficult to define optional params that can be null, meaning a typical PUT or PATCH request to "unset" a value. Say, you have a DB column that needs to be NULLed.
Of course, you still get the "undef"s from req->raisin_parameters, so it can easily be circumvented, but I am still unsure why "undef"s should be removed from declared_params and params?

Is line 34 actually neccessary, is my point.

[khrt]

Right, the way it's implemented right now doesn't make much sense and might be fixed.

[meylingtaing]

Hi! I'm currently using this perl module for a project, and I ran into this issue. We need to be able to differentiate between passing a parameter with value undef, and not passing that parameter at all. What needs to happen to get this fix worked on?

[khrt]

Hi @meylingtaing, at the moment I do have much time to work on this.

There is a work-in-progress polettix@48a9e86 stared by @polettix, maybe it can be adopted somehow.

I'll try to do my best to resolve the issue, but unfortunately cannot give you any estimates on this.