fix: jira update ticket (#5122)

Author: shahargl

docs/snippets/providers/jira-snippet-autogenerated.mdx

@@ -1,4 +1,4 @@
-{/* This snippet is automatically generated using scripts/docs_render_provider_snippets.py 
+{/* This snippet is automatically generated using scripts/docs_render_provider_snippets.py
 Do not edit it manually, as it will be overwritten */}
 
 ## Authentication
@@ -8,12 +8,12 @@ This provider requires authentication.
 - **host**: Atlassian Jira Host (required: True, sensitive: False)
 
 Certain scopes may be required to perform specific actions or queries via the provider. Below is a summary of relevant scopes and their use cases:
-- **BROWSE_PROJECTS**: Browse Jira Projects (mandatory) 
-- **CREATE_ISSUES**: Create Jira Issues (mandatory) 
-- **CLOSE_ISSUES**: Close Jira Issues  
-- **EDIT_ISSUES**: Edit Jira Issues  
-- **DELETE_ISSUES**: Delete Jira Issues  
-- **MODIFY_REPORTER**: Modify Jira Issue Reporter  
+- **BROWSE_PROJECTS**: Browse Jira Projects (mandatory)
+- **CREATE_ISSUES**: Create Jira Issues (mandatory)
+- **CLOSE_ISSUES**: Close Jira Issues
+- **EDIT_ISSUES**: Edit Jira Issues
+- **DELETE_ISSUES**: Delete Jira Issues
+- **MODIFY_REPORTER**: Modify Jira Issue Reporter
 
 
 
@@ -59,4 +59,6 @@ Check the following workflow examples:
 - [create_jira_ticket_upon_alerts.yml](https://github.com/keephq/keep/blob/main/examples/workflows/create_jira_ticket_upon_alerts.yml)
 - [incident-enrich.yaml](https://github.com/keephq/keep/blob/main/examples/workflows/incident-enrich.yaml)
 - [jira_on_prem.yml](https://github.com/keephq/keep/blob/main/examples/workflows/jira_on_prem.yml)
+- [test_jira_create_with_custom_fields.yml](https://github.com/keephq/keep/blob/main/examples/workflows/test_jira_create_with_custom_fields.yml)
+- [test_jira_custom_fields_fix.yml](https://github.com/keephq/keep/blob/main/examples/workflows/test_jira_custom_fields_fix.yml)
 - [update_jira_ticket.yml](https://github.com/keephq/keep/blob/main/examples/workflows/update_jira_ticket.yml)

examples/workflows/test_jira_create_with_custom_fields.yml

@@ -0,0 +1,26 @@
+workflow:
+  id: test-jira-create-custom-fields
+  name: Test Jira Create with Custom Fields
+  description: Test workflow to demonstrate CREATE operations with custom fields
+  disabled: false
+  triggers:
+    - type: manual
+  inputs: []
+  consts: {}
+  owners: []
+  services: []
+  steps: []
+  actions:
+    - name: jira-action
+      provider:
+        type: jira
+        config: "{{ providers.jira }}"
+        with:
+          project_key: "TEST"
+          board_name: "TEST"
+          summary: "Create new issue with custom fields"
+          description: "This is a test issue created with custom fields"
+          issue_type: "Task"
+          custom_fields:
+            customfield_10696: "10"
+            customfield_10201: "Critical"

examples/workflows/test_jira_custom_fields_fix.yml

@@ -0,0 +1,27 @@
+workflow:
+  id: test-jira-custom-fields-fix
+  name: Test Jira Custom Fields Fix
+  description: Test workflow to demonstrate the fix for Jira custom fields update issue
+  disabled: false
+  triggers:
+    - type: manual
+  inputs: []
+  consts: {}
+  owners: []
+  services: []
+  steps: []
+  actions:
+    - name: jira-action
+      provider:
+        type: jira
+        config: "{{ providers.jira }}"
+        with:
+          issue_id: "{{ incident.ticket_id }}"
+          project_key: "TEST"
+          board_name: "TEST"
+          summary: "Update summary of an issue"
+          description: "Test description"
+          issue_type: "Task"
+          custom_fields:
+            customfield_10696: "10"
+            customfield_10201: "Critical"

keep/providers/jira_provider/jira_provider.py

@@ -348,7 +348,9 @@ def __update_issue(
                 update["labels"] = [{"set": label} for label in labels]
 
             if custom_fields:
-                update.update(custom_fields)
+                # Format custom fields properly for Jira API
+                for field_name, field_value in custom_fields.items():
+                    update[field_name] = [{"set": field_value}]
 
             request_body = {"update": update}
 
@@ -437,7 +439,13 @@ def _notify(
             components (List[str]): The components of the issue.
             custom_fields (dict): The custom fields of the issue.
         """
-        issue_type = issue_type if issue_type else kwargs.get("issuetype", "Task")
+        issue_type = (
+            issue_type
+            if issue_type
+            else (
+                kwargs.get("issuetype", "Task") if isinstance(kwargs, dict) else "Task"
+            )
+        )
         if labels and isinstance(labels, str):
             labels = json.loads(labels.replace("'", '"'))
         try:

keep/providers/jiraonprem_provider/jiraonprem_provider.py

@@ -14,13 +14,14 @@
 from keep.exceptions.provider_exception import ProviderException
 from keep.providers.base.base_provider import BaseProvider
 from keep.providers.models.provider_config import ProviderConfig, ProviderScope
+from keep.validation.fields import HttpsUrl
 
 
 @pydantic.dataclasses.dataclass
 class JiraonpremProviderAuthConfig:
     """Jira On Prem authentication configuration."""
 
-    host: pydantic.AnyHttpUrl = dataclasses.field(
+    host: HttpsUrl = dataclasses.field(
         metadata={
             "required": True,
             "description": "Jira Host",
@@ -366,7 +367,9 @@ def __update_issue(
                 update["labels"] = [{"set": label} for label in labels]
 
             if custom_fields:
-                update.update(custom_fields)
+                # Format custom fields properly for Jira API
+                for field_name, field_value in custom_fields.items():
+                    update[field_name] = [{"set": field_value}]
 
             request_body = {"update": update}
 
@@ -497,7 +500,13 @@ def _notify(
         Notify jira by creating an issue.
         """
         # if the user didn't provider a project_key, try to extract it from the board name
-        issue_type = issue_type if issue_type else kwargs.get("issuetype", "Task")
+        issue_type = (
+            issue_type
+            if issue_type
+            else (
+                kwargs.get("issuetype", "Task") if isinstance(kwargs, dict) else "Task"
+            )
+        )
         if labels and isinstance(labels, str):
             labels = json.loads(labels.replace("'", '"'))
         try:

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "keep"
-version = "0.45.9"
+version = "0.45.10"
 description = "Alerting. for developers, by developers."
 authors = ["Keep Alerting LTD"]
 packages = [{include = "keep"}]