fix: incident ticket linking modal ticket_id field to be optional (#5300)

Author: DolevNe

keep-ui/entities/incidents/lib/__tests__/ticketing-utils.test.ts

@@ -212,13 +212,13 @@ describe("ticketing-utils", () => {
   describe("findLinkedTicket", () => {
     it("should find linked ticket for ServiceNow", () => {
       const incident = createMockIncident({
-        servicenow_ticket_id: "INC0012345"
+        servicenow_ticket_url: "https://company.service-now.com/now/nav/ui/classic/params/target/incident.do%3Fsys_id%3DINC0012345"
       });
       const result = findLinkedTicket(incident, [mockServiceNowProvider]);
       expect(result).toEqual({
         provider: mockServiceNowProvider,
-        ticketId: "INC0012345",
-        key: "servicenow_ticket_id"
+        ticketUrl: "https://company.service-now.com/now/nav/ui/classic/params/target/incident.do%3Fsys_id%3DINC0012345",
+        key: "servicenow_ticket_url"
       });
     });
 

keep-ui/entities/incidents/lib/ticketing-utils.ts

@@ -3,7 +3,7 @@ import { type IncidentDto } from "@/entities/incidents/model";
 
 export interface LinkedTicket {
   provider: Provider;
-  ticketId: string;
+  ticketUrl: string;
   key: string;
 }
 
@@ -59,13 +59,13 @@ export function getTicketCreateUrl(provider: Provider, description: string = "",
 export function findLinkedTicket(incident: any, ticketingProviders: Provider[]): LinkedTicket | null {
   if (!incident.enrichments) return null;
 
-  // Look for any ticketing provider's ticket ID in enrichments
+  // Look for any ticketing provider's ticket URL in enrichments
   for (const provider of ticketingProviders) {
-    const ticketKey = `${provider.type}_ticket_id`;
+    const ticketKey = `${provider.type}_ticket_url`;
     if (incident.enrichments[ticketKey]) {
       return {
         provider,
-        ticketId: incident.enrichments[ticketKey],
+        ticketUrl: incident.enrichments[ticketKey],
         key: ticketKey
       };
     }

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "keep"
-version = "0.47.8"
+version = "0.47.9"
 description = "Alerting. for developers, by developers."
 authors = ["Keep Alerting LTD"]
 packages = [{include = "keep"}]