The priority of configuration files and command lines in Karmadactl init.

[luyb177]

Why do you think this document is needed:

The content of this article may need modifications: Article Path

The following content may be incorrect:

Overriding Configuration File Values

If necessary, command line flags can still be used in conjunction with the configuration file. The parameters specified via the command line will override those in the configuration file. For example, to override the number of API server replicas, you could use:

karmadactl init --config /path/to/karmada-init.yaml --karmada-apiserver-replicas 5

According to the code implementation:

setIfNotZeroInt32(&i.KarmadaAPIServerReplicas, apiServer.CommonSettings.Replicas)

// setIfNotEmpty checks if the source string is not empty, and if so, assigns its value to the destination string.
func setIfNotEmpty(dest *string, src string) {
  if src != "" {
  	*dest = src
  }
}

Since the assignment of i.KarmadaAPIServerReplicas using the command line occurs earlier than the assignment from parsing the configuration file, it will override the value passed from the command line, rather than the command line value overriding the value passed from the configuration file.

[luyb177]

Hello @tiansuo114 , I have a question regarding the priority relationship between configuration files and command-line flags for karmadactl init configuration. Currently, the descriptions on the proposal and the website are inconsistent:

karmada/docs/proposals/karmadactl/init-configuration-file.md

• When the user has a karmadactl init file, they can use the --config flag to specify that karmadactl init should read the configuration from the specified config file. Additionally, external cmd flags can still be used. In the design, if there are overlapping parts between the two, the configuration file configuration items will take higher priority.

According to the proposal, the configuration file has higher priority.
According to the website, command-line flags have higher priority.
Could you help confirm whether this is a documentation error or if the design changed during implementation?
Thanks~