reduce unnecessary watch events in execution-status-controller

Signed-off-by: rohan-019 <[email protected]>

Author: rohan-019

pkg/controllers/execution/execution_controller.go

@@ -36,6 +36,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller"
 	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
+	"sigs.k8s.io/controller-runtime/pkg/event"
 	"sigs.k8s.io/controller-runtime/pkg/predicate"
 
 	clusterv1alpha1 "github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1"
@@ -133,21 +134,44 @@ func (c *Controller) Reconcile(ctx context.Context, req controllerruntime.Reques
 
 // SetupWithManager creates a controller and register to controller manager.
 func (c *Controller) SetupWithManager(mgr controllerruntime.Manager) error {
-	ctrlBuilder := controllerruntime.NewControllerManagedBy(mgr).Named(ControllerName).
-		WithEventFilter(predicate.GenerationChangedPredicate{}).
-		WithOptions(controller.Options{
+    ctrlBuilder := controllerruntime.NewControllerManagedBy(mgr).Named(ControllerName).
+        WithOptions(controller.Options{
 			RateLimiter: ratelimiterflag.DefaultControllerRateLimiter[controllerruntime.Request](c.RateLimiterOptions),
 		})
 
+    // Build the default predicate: allow generation changes and nil->non-nil deletion timestamp transitions; ignore delete events.
+    defaultPred := buildWorkEventPredicate()
+
 	if c.WorkPredicateFunc != nil {
-		ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(c.WorkPredicateFunc))
+        ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(c.WorkPredicateFunc, defaultPred))
 	} else {
-		ctrlBuilder.For(&workv1alpha1.Work{})
+        ctrlBuilder.For(&workv1alpha1.Work{}, builder.WithPredicates(defaultPred))
 	}
 
 	return ctrlBuilder.Complete(c)
 }
 
+// buildWorkEventPredicate returns the default predicate used to watch Work objects:
+// - Reconcile on generation changes
+// - Reconcile when deletion timestamp changes from nil to non-nil (finalizer path)
+// - Ignore delete events
+func buildWorkEventPredicate() predicate.Predicate {
+    return predicate.Funcs{
+        UpdateFunc: func(e event.UpdateEvent) bool {
+            if e.ObjectOld == nil || e.ObjectNew == nil {
+                return false
+            }
+            // Trigger when deletion timestamp transitions from nil to non-nil
+            if e.ObjectOld.GetDeletionTimestamp().IsZero() && !e.ObjectNew.GetDeletionTimestamp().IsZero() {
+                return true
+            }
+            // Trigger on generation change
+            return e.ObjectOld.GetGeneration() != e.ObjectNew.GetGeneration()
+        },
+        DeleteFunc: func(event.DeleteEvent) bool { return false },
+    }
+}
+
 func (c *Controller) syncWork(ctx context.Context, clusterName string, work *workv1alpha1.Work) (controllerruntime.Result, error) {
 	start := time.Now()
 	err := c.syncToClusters(ctx, clusterName, work)

pkg/controllers/execution/execution_controller_predicate_test.go

@@ -0,0 +1,97 @@
+/*
+Copyright 2025 The Karmada Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package execution
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"sigs.k8s.io/controller-runtime/pkg/event"
+
+	workv1alpha1 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha1"
+)
+
+// newWorkWithGenAndDeletion returns a Work with the specified generation and deletion timestamp presence.
+func newWorkWithGenAndDeletion(generation int64, deleted bool) *workv1alpha1.Work {
+    w := &workv1alpha1.Work{}
+    w.SetGeneration(generation)
+    if deleted {
+        now := metav1.Now()
+        w.SetDeletionTimestamp(&now)
+    }
+    return w
+}
+
+func TestBuildWorkEventPredicate_Update_GenerationChange(t *testing.T) {
+    pred := buildWorkEventPredicate()
+
+    oldObj := newWorkWithGenAndDeletion(1, false)
+    newObj := newWorkWithGenAndDeletion(2, false)
+
+    allow := pred.Update(event.UpdateEvent{ObjectOld: oldObj, ObjectNew: newObj})
+    assert.True(t, allow)
+}
+
+func TestBuildWorkEventPredicate_Update_DeletionTimestamp_NilToNonNil(t *testing.T) {
+    pred := buildWorkEventPredicate()
+
+    oldObj := newWorkWithGenAndDeletion(1, false)
+    newObj := newWorkWithGenAndDeletion(1, true)
+
+    allow := pred.Update(event.UpdateEvent{ObjectOld: oldObj, ObjectNew: newObj})
+    assert.True(t, allow)
+}
+
+func TestBuildWorkEventPredicate_Update_DeletionTimestamp_NonNilToNonNil(t *testing.T) {
+    pred := buildWorkEventPredicate()
+
+    oldObj := newWorkWithGenAndDeletion(1, true)
+    newObj := newWorkWithGenAndDeletion(1, true)
+
+    allow := pred.Update(event.UpdateEvent{ObjectOld: oldObj, ObjectNew: newObj})
+    assert.False(t, allow)
+}
+
+func TestBuildWorkEventPredicate_Update_NoChange(t *testing.T) {
+    pred := buildWorkEventPredicate()
+
+    oldObj := newWorkWithGenAndDeletion(1, false)
+    newObj := newWorkWithGenAndDeletion(1, false)
+
+    allow := pred.Update(event.UpdateEvent{ObjectOld: oldObj, ObjectNew: newObj})
+    assert.False(t, allow)
+}
+
+func TestBuildWorkEventPredicate_Delete_Ignored(t *testing.T) {
+    pred := buildWorkEventPredicate()
+
+    obj := newWorkWithGenAndDeletion(1, true)
+    allow := pred.Delete(event.DeleteEvent{Object: obj})
+    assert.False(t, allow)
+}
+
+func TestBuildWorkEventPredicate_Update_NilSafety(t *testing.T) {
+    pred := buildWorkEventPredicate()
+
+    obj := newWorkWithGenAndDeletion(1, false)
+
+    assert.False(t, pred.Update(event.UpdateEvent{ObjectOld: nil, ObjectNew: obj}))
+    assert.False(t, pred.Update(event.UpdateEvent{ObjectOld: obj, ObjectNew: nil}))
+}
+
+