operator: avoid invalid reconcile

Signed-off-by: zhzhuang-zju <[email protected]>

Author: zhzhuang-zju

operator/pkg/controller/karmada/controller.go

@@ -176,12 +176,15 @@ func skipIfSuspended() predicate.Predicate {
 // 1. when the karmada cr is deleted.
 // 2. when the spec of karmada cr is updated.
 func (ctrl *Controller) onKarmadaUpdate(updateEvent event.UpdateEvent) bool {
-	newObj := updateEvent.ObjectNew.(*operatorv1alpha1.Karmada)
-	oldObj := updateEvent.ObjectOld.(*operatorv1alpha1.Karmada)
+	newObj := updateEvent.ObjectNew.(*operatorv1alpha1.Karmada).DeepCopy()
+	oldObj := updateEvent.ObjectOld.(*operatorv1alpha1.Karmada).DeepCopy()
 
 	if !newObj.DeletionTimestamp.IsZero() {
 		return true
 	}
 
+	// TODO(@zhzhuang-zju): If default values are set via an admission controller, the default() call below can be omitted.
+	operatorscheme.Scheme.Default(newObj)
+	operatorscheme.Scheme.Default(oldObj)
 	return !reflect.DeepEqual(newObj.Spec, oldObj.Spec)
 }