Fix linter errors for unchecked return values

Author: thrawn01

.github/workflows/lint.yaml

@@ -11,7 +11,7 @@ on:
       - main
 
 env:
-  GOLANGCI_LINT_VERSION: v1.61.0
+  GOLANGCI_LINT_VERSION: v2.2.1
 
 jobs:
   lint:
@@ -34,7 +34,7 @@ jobs:
         run: go mod tidy && git diff --exit-code
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v8
         with:
           version: ${{ env.GOLANGCI_LINT_VERSION }}
           skip-cache: true # cache/restore is done by actions/setup-go@v3 step

Makefile

@@ -1,6 +1,6 @@
 .DEFAULT_GOAL := build
 LINT = $(GOPATH)/bin/golangci-lint
-LINT_VERSION = v1.64.6
+LINT_VERSION = v2.2.1
 VERSION=$(shell git describe --tags --exact-match 2>/dev/null || echo "dev-build")
 
 .PHONY: install

daemon/daemon.go

@@ -131,13 +131,13 @@ func (d *Daemon) Client() (*querator.Client, error) {
 		// Serve the server side of the pipe through the InMemoryListener
 		if inMemListener, ok := d.Listener.(*InMemoryListener); ok {
 			if err := inMemListener.ServeConn(serverConn); err != nil {
-				clientConn.Close()
-				serverConn.Close()
+				_ = clientConn.Close()
+				_ = serverConn.Close()
 				return nil, fmt.Errorf("failed to serve connection: %w", err)
 			}
 		} else {
-			clientConn.Close()
-			serverConn.Close()
+			_ = clientConn.Close()
+			_ = serverConn.Close()
 			return nil, fmt.Errorf("InMemoryListener is enabled but listener is not of type *InMemoryListener")
 		}
 

daemon/listener_test.go

@@ -20,11 +20,11 @@ func TestInMemoryListener(t *testing.T) {
 	listener := daemon.NewInMemoryListener()
 	server := &http.Server{
 		Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-			fmt.Fprintf(w, "Hello, %s!", r.URL.Path[1:])
+			_, _ = fmt.Fprintf(w, "Hello, %s!", r.URL.Path[1:])
 		}),
 	}
-	go server.Serve(listener)
-	defer server.Close()
+	go func() { _ = server.Serve(listener) }()
+	defer func() { _ = server.Close() }()
 
 	clientCount := 3
 	var wg sync.WaitGroup
@@ -34,7 +34,7 @@ func TestInMemoryListener(t *testing.T) {
 			defer wg.Done()
 			// Each client gets its own net.Pipe
 			serverConn, clientConn := net.Pipe()
-			listener.ServeConn(serverConn)
+			_ = listener.ServeConn(serverConn)
 
 			// Custom DialContext returns the clientConn for this request
 			dialOnce := sync.Once{}
@@ -56,7 +56,7 @@ func TestInMemoryListener(t *testing.T) {
 				t.Errorf("client %d error: %v", id, err)
 				return
 			}
-			defer resp.Body.Close()
+			defer func() { _ = resp.Body.Close() }()
 			body, _ := io.ReadAll(resp.Body)
 			expected := fmt.Sprintf("Hello, client%d!", id)
 			if !strings.Contains(string(body), expected) {
@@ -65,7 +65,7 @@ func TestInMemoryListener(t *testing.T) {
 		}(i)
 	}
 	wg.Wait()
-	listener.Close()
+	_ = listener.Close()
 }
 
 func TestDaemonInMemoryListener(t *testing.T) {
@@ -76,7 +76,7 @@ func TestDaemonInMemoryListener(t *testing.T) {
 		InMemoryListener: true,
 	})
 	require.NoError(t, err)
-	defer d.Shutdown(ctx)
+	defer func() { _ = d.Shutdown(ctx) }()
 
 	// Get a client - should create a new net.Pipe connection
 	{