You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The changes are all in my local repository.
Let me know if you're OK with it and I'll send a pull request.
You can create a new package on the command line in Windows by downloading nuget.exe to the same directory as the .csproj and typing this in a Developer Command Prompt in that directory: > nuget pack
Actually, there is one more thing that concerns me now: how do we publish these? Is it possible to somehow register a team account or something, to publish something from a team's name, like "officially"? I see that, for example, Google's packages look like that: https://www.nuget.org/packages/Google.Protobuf/ <= i.e. with "The ID prefix of this package has been reserved for one of the owners of this package by NuGet.org." and it comes from special protobuf-packages account...
Excellent question. Publishing was very easy, just a drag and drop of the nupkg file into the browser and fill in a few fields. I set up a personal account but I’m sure you can up an official Kaitai one. I’m happy to hand over the package name and Renaming it to Kaitai.Struct.Runtime makes sense. I can setup the NuGet account if you like. It just needs a verifiable email address.
Just got https://www.nuget.org/profiles/kaitai registered, I'll try to publish "official" v0.7 shortly. @Arlorean, if you feel like supporting that NuGet package and publishing it, let me know, I can send you the login/password for that account. Ideally, it would be super cool if we'll set up Travis CI to publish "unstable" runtime build every time code is changed in CI, if that's possible.
Hi!
I've noticed that when using nuget package with .net core project following warning appears:
warning NU1701: Package 'KaitaiStruct.Runtime.CSharp 0.7.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.2'. This package may not be fully compatible with your project.
I tested it under .net core linux and it appear to actually work correctly, but the warning is annoying. Since from what it looks the library uses only very basic .net stuff, updating csproj file should probably be enough to fix that.
Activity
Arlorean commentedon Jan 21, 2018
I'll give this a go now. How hard can it be? :)
GreyCat commentedon Jan 21, 2018
Shouldn't be that hard. If you know how to do that — you're most welcome to give it a shot :)
Arlorean commentedon Jan 21, 2018
OK. I've uploaded KaitaiStruct.Runtime.CSharp.0.7.0.nupkg file to nuget.org:
https://www.nuget.org/packages/KaitaiStruct.Runtime.CSharp/0.7.0
The changes are all in my local repository.
Let me know if you're OK with it and I'll send a pull request.
You can create a new package on the command line in Windows by downloading nuget.exe to the same directory as the .csproj and typing this in a Developer Command Prompt in that directory:
> nuget pack
Here's what it looks like in my VisualStudio when I was testing it locally. My .sln file was called KaitaiVox so you can ignore those references in the image:
https://drive.google.com/file/d/1pJYVkPP63y-xO2Wz9cj0duzG-rNbJoMV/view?usp=sharing
Arlorean commentedon Jan 21, 2018
Done. Sorry I didn't put the #6 issue number in the commit comments.
PR is at #7
GreyCat commentedon Jan 21, 2018
Actually, there is one more thing that concerns me now: how do we publish these? Is it possible to somehow register a team account or something, to publish something from a team's name, like "officially"? I see that, for example, Google's packages look like that: https://www.nuget.org/packages/Google.Protobuf/ <= i.e. with "The ID prefix of this package has been reserved for one of the owners of this package by NuGet.org." and it comes from special protobuf-packages account...
Arlorean commentedon Jan 22, 2018
Excellent question. Publishing was very easy, just a drag and drop of the nupkg file into the browser and fill in a few fields. I set up a personal account but I’m sure you can up an official Kaitai one. I’m happy to hand over the package name and Renaming it to Kaitai.Struct.Runtime makes sense. I can setup the NuGet account if you like. It just needs a verifiable email address.
Sent with GitHawk
GreyCat commentedon Jan 22, 2018
Just got https://www.nuget.org/profiles/kaitai registered, I'll try to publish "official" v0.7 shortly. @Arlorean, if you feel like supporting that NuGet package and publishing it, let me know, I can send you the login/password for that account. Ideally, it would be super cool if we'll set up Travis CI to publish "unstable" runtime build every time code is changed in CI, if that's possible.
arekbulski commentedon Jan 23, 2018
I need your advise on #9
mishun commentedon May 13, 2019
Hi!
I've noticed that when using nuget package with .net core project following warning appears:
I tested it under .net core linux and it appear to actually work correctly, but the warning is annoying. Since from what it looks the library uses only very basic .net stuff, updating csproj file should probably be enough to fix that.
GreyCat commentedon May 13, 2019
@mishun Please consider contributing a PR that will fix that csproj file to make it work the way you want it.
KOLANICH commentedon May 13, 2019
https://github.com/features/package-registry
pluskal commentedon Dec 12, 2019
I think that newer version of NuGet package can be build now.
#15 solved the problem of targeting in .NET CORE.
Merge branch '6-nullable-t-for-optional-fields-are-call' into 'master'
1 remaining item