remove unneeded function add comments

Signed-off-by: craig <[email protected]>

Author: maleck13

internal/mcp-router/headers.go

@@ -15,7 +15,8 @@ const (
 	authorityHeader       = ":authority"
 	authorizationHeader   = "authorization"
 	mcpTarget             = "mcp-target"
-	RoutingKey            = "router-key"
+	// RoutingKey is an internal header used to authenticate a request from the router
+	RoutingKey = "router-key"
 )
 
 func getSingleValueHeader(headers *basepb.HeaderMap, name string) string {

internal/mcp-router/request_handlers.go

@@ -78,19 +78,6 @@ func (mr *MCPRequest) GetSingleHeaderValue(key string) string {
 	return getSingleValueHeader(mr.Headers, key)
 }
 
-func (mr *MCPRequest) RemoveHeader(key string) {
-	headers := []*corev3.HeaderValue{}
-	if mr.Headers == nil {
-		return
-	}
-	for _, h := range mr.Headers.Headers {
-		if h.Key != key {
-			headers = append(headers, h)
-		}
-	}
-	mr.Headers.Headers = headers
-}
-
 // GetSessionID returns the mcp session id
 func (mr *MCPRequest) GetSessionID() string {
 	if mr.sessionID == "" {

internal/mcp-router/request_handlers_test.go

@@ -243,91 +243,6 @@ func TestHandleRequestBody(t *testing.T) {
 		string(rb.RequestBody.Response.BodyMutation.GetBody()))
 }
 
-func TestRemoveHeader(t *testing.T) {
-	testCases := []struct {
-		Name            string
-		Headers         *corev3.HeaderMap
-		KeyToRemove     string
-		ExpectedHeaders []*corev3.HeaderValue
-	}{
-		{
-			Name: "removes single matching header",
-			Headers: &corev3.HeaderMap{
-				Headers: []*corev3.HeaderValue{
-					{Key: "x-test", RawValue: []byte("value1")},
-					{Key: "x-keep", RawValue: []byte("value2")},
-				},
-			},
-			KeyToRemove: "x-test",
-			ExpectedHeaders: []*corev3.HeaderValue{
-				{Key: "x-keep", RawValue: []byte("value2")},
-			},
-		},
-		{
-			Name: "removes multiple matching headers",
-			Headers: &corev3.HeaderMap{
-				Headers: []*corev3.HeaderValue{
-					{Key: "x-duplicate", RawValue: []byte("value1")},
-					{Key: "x-keep", RawValue: []byte("value2")},
-					{Key: "x-duplicate", RawValue: []byte("value3")},
-				},
-			},
-			KeyToRemove: "x-duplicate",
-			ExpectedHeaders: []*corev3.HeaderValue{
-				{Key: "x-keep", RawValue: []byte("value2")},
-			},
-		},
-		{
-			Name: "does nothing when key not found",
-			Headers: &corev3.HeaderMap{
-				Headers: []*corev3.HeaderValue{
-					{Key: "x-keep1", RawValue: []byte("value1")},
-					{Key: "x-keep2", RawValue: []byte("value2")},
-				},
-			},
-			KeyToRemove: "x-nonexistent",
-			ExpectedHeaders: []*corev3.HeaderValue{
-				{Key: "x-keep1", RawValue: []byte("value1")},
-				{Key: "x-keep2", RawValue: []byte("value2")},
-			},
-		},
-		{
-			Name: "handles empty header map",
-			Headers: &corev3.HeaderMap{
-				Headers: []*corev3.HeaderValue{},
-			},
-			KeyToRemove:     "x-test",
-			ExpectedHeaders: []*corev3.HeaderValue{},
-		},
-		{
-			Name:            "handles nil header map",
-			Headers:         nil,
-			KeyToRemove:     "x-test",
-			ExpectedHeaders: nil,
-		},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.Name, func(t *testing.T) {
-			mcpReq := &MCPRequest{
-				Headers: tc.Headers,
-			}
-
-			mcpReq.RemoveHeader(tc.KeyToRemove)
-
-			if tc.ExpectedHeaders == nil {
-				require.Nil(t, mcpReq.Headers)
-			} else {
-				require.Equal(t, len(tc.ExpectedHeaders), len(mcpReq.Headers.Headers))
-				for i, expectedHeader := range tc.ExpectedHeaders {
-					require.Equal(t, expectedHeader.Key, mcpReq.Headers.Headers[i].Key)
-					require.Equal(t, expectedHeader.RawValue, mcpReq.Headers.Headers[i].RawValue)
-				}
-			}
-		})
-	}
-}
-
 func TestHandleRequestHeaders(t *testing.T) {
 	logger := slog.New(slog.NewTextHandler(os.Stdout, nil))
 

internal/mcp-router/response_bulder.go

@@ -71,6 +71,7 @@ func (rb *ResponseBuilder) WithRequestBodyHeadersResponse(headers []*basepb.Head
 	return rb
 }
 
+// WithRequestBodySetUnsetHeadersResponse will set and unset headers in the request
 func (rb *ResponseBuilder) WithRequestBodySetUnsetHeadersResponse(set []*basepb.HeaderValueOption, unset []string) *ResponseBuilder {
 	rb.response = append(rb.response, &eppb.ProcessingResponse{
 		Response: &eppb.ProcessingResponse_RequestBody{