Merge pull request #859 from zeeke/log/try-get-interface-name

logging: avoid `TryGetInterfaceName` logs

Author: zeeke

cmd/sriov-network-config-daemon/service.go

@@ -368,6 +368,7 @@ func (s *ServiceConfig) waitForDevicesInitialization() {
 	for time.Now().Before(deadline) {
 		for pciAddr, name := range devicesToWait {
 			if s.hostHelper.TryGetInterfaceName(pciAddr) == name {
+				s.log.Info("Device ready", "pci", pciAddr, "name", name)
 				delete(devicesToWait, pciAddr)
 			}
 		}

pkg/host/internal/network/network.go

@@ -75,7 +75,6 @@ func (n *network) TryToGetVirtualInterfaceName(pciAddr string) string {
 func (n *network) TryGetInterfaceName(pciAddr string) string {
 	names, err := n.dputilsLib.GetNetNames(pciAddr)
 	if err != nil || len(names) < 1 {
-		log.Log.V(2).Info("TryGetInterfaceName(): failed to get interface name", "err", err, "pciAddress", pciAddr)
 		return ""
 	}
 	netDevName := names[0]
@@ -96,7 +95,6 @@ func (n *network) TryGetInterfaceName(pciAddr string) string {
 		return name
 	}
 
-	log.Log.V(2).Info("TryGetInterfaceName()", "name", netDevName)
 	return netDevName
 }
 

pkg/host/internal/sriov/sriov.go

@@ -176,7 +176,7 @@ func (s *sriov) VFIsReady(pciAddr string) (netlink.Link, error) {
 	err = wait.PollImmediate(time.Second, 10*time.Second, func() (bool, error) {
 		vfIndex, err := s.networkHelper.GetInterfaceIndex(pciAddr)
 		if err != nil {
-			log.Log.Error(err, "VFIsReady(): invalid index number")
+			log.Log.Error(err, "VFIsReady(): invalid index number", "device", pciAddr)
 			return false, nil
 		}
 		vfLink, err = s.netlinkLib.LinkByIndex(vfIndex)