Merge pull request #101 from nocturnalastro/better_role_error_log

nocturnalastro · web-flow · commit 4603c2313d94 · 2025-09-30T15:48:02.000+01:00
tests: Improve logging message when incorrect log is found
diff --git a/test/pkg/metrics/metrics.go b/test/pkg/metrics/metrics.go
@@ -148,7 +148,7 @@ func CheckClockRole(roles []MetricRole, Ifs []string, nodeName *string) (err err
 			return fmt.Errorf("error strconv for roleString=%s, err:%s", roleString, err)
 		}
 		if MetricRole(roleInt) != roles[index] {
-			return fmt.Errorf(fmt.Sprintf("incorrect role, role expected=%d, role observed=%d(%s)", roles[index], roleInt, roleString))
+			return fmt.Errorf(fmt.Sprintf("incorrect role, role expected=%d(%s), role observed=%d(%s)", roles[index], roles[index].String(), roleInt, MetricRole(roleInt).String()))
 		}
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ func CheckClockRole(roles []MetricRole, Ifs []string, nodeName *string) (err err`
`148`	`148`	`return fmt.Errorf("error strconv for roleString=%s, err:%s", roleString, err)`
`149`	`149`	`}`
`150`	`150`	`if MetricRole(roleInt) != roles[index] {`
`151`		`- return fmt.Errorf(fmt.Sprintf("incorrect role, role expected=%d, role observed=%d(%s)", roles[index], roleInt, roleString))`
	`151`	`+ return fmt.Errorf(fmt.Sprintf("incorrect role, role expected=%d(%s), role observed=%d(%s)", roles[index], roles[index].String(), roleInt, MetricRole(roleInt).String()))`
`152`	`152`	`}`
`153`	`153`	`}`
`154`	`154`	`return nil`