fix: only log slow sql query parameters if trace logging is enabled

john-from-corelight · vitorsavian · commit b6a31549dcc8 · 2024-07-01T11:21:59.000-03:00
Signed-off-by: john.mezger &lt;john.mezger@corelight.com&gt;
diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -43,6 +43,10 @@ func ObserveSQL(start time.Time, errCode string, sql util.Stripped, args ...inte
 	duration := time.Since(start)
 	SQLTime.WithLabelValues(errCode).Observe(duration.Seconds())
 	if SlowSQLThreshold > 0 && duration >= SlowSQLThreshold {
-		logrus.Infof("Slow SQL (started: %v) (total time: %v): %s : %v", start, duration, sql, args)
+		if logrus.GetLevel() == logrus.TraceLevel {
+			logrus.Tracef("Slow SQL (started: %v) (total time: %v): %s : %v", start, duration, sql, args)
+		} else {
+			logrus.Infof("Slow SQL (started: %v) (total time: %v): %s", start, duration, sql)
+		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,10 @@ func ObserveSQL(start time.Time, errCode string, sql util.Stripped, args ...inte`
`43`	`43`	`duration := time.Since(start)`
`44`	`44`	`SQLTime.WithLabelValues(errCode).Observe(duration.Seconds())`
`45`	`45`	`if SlowSQLThreshold > 0 && duration >= SlowSQLThreshold {`
`46`		`- logrus.Infof("Slow SQL (started: %v) (total time: %v): %s : %v", start, duration, sql, args)`
	`46`	`+ if logrus.GetLevel() == logrus.TraceLevel {`
	`47`	`+ logrus.Tracef("Slow SQL (started: %v) (total time: %v): %s : %v", start, duration, sql, args)`
	`48`	`+ } else {`
	`49`	`+ logrus.Infof("Slow SQL (started: %v) (total time: %v): %s", start, duration, sql)`
	`50`	`+ }`
`47`	`51`	`}`
`48`	`52`	`}`