Do not register core metrics in init

Fixes panic when both etcd and kine are in use

Signed-off-by: Brad Davidson <[email protected]>

Author: brandond

pkg/app/app.go

@@ -198,8 +198,9 @@ func run(c *cli.Context) error {
 	if !metricsIgnoreTLSConfig {
 		metricsConfig.ServerTLSConfig = config.ServerTLSConfig
 	}
-	go metrics.Serve(ctx, metricsConfig)
 	config.MetricsRegisterer = metrics.Registry
+	metrics.RegisterCoreCollectors()
+	go metrics.Serve(ctx, metricsConfig)
 	_, err := endpoint.Listen(ctx, config)
 	if err != nil {
 		return err

pkg/metrics/registry.go

@@ -12,7 +12,7 @@ type RegistererGatherer interface {
 
 var Registry RegistererGatherer = prometheus.NewRegistry()
 
-func init() {
+func RegisterCoreCollectors() {
 	Registry.MustRegister(
 		// expose process metrics like CPU, Memory, file descriptor usage etc.
 		collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}),