Skip to content

Commit 9c6ee5d

Browse files
authored
Expose the cell toolbar settings (#7766)
1 parent 6923a84 commit 9c6ee5d

File tree

2 files changed

+17
-14
lines changed

2 files changed

+17
-14
lines changed

app/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@
319319
"@jupyterlab/video-extension": true
320320
},
321321
"/tree": {
322+
"@jupyterlab/cell-toolbar-extension": true,
322323
"@jupyterlab/extensionmanager-extension": true,
323324
"@jupyterlab/filebrowser-extension": [
324325
"@jupyterlab/filebrowser-extension:browser",

packages/tree-extension/src/index.ts

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -280,20 +280,22 @@ const loadPlugins: JupyterFrontEndPlugin<void> = {
280280

281281
app.restored.then(async () => {
282282
const plugins = await connector.list('all');
283-
plugins.ids.forEach(async (id: string) => {
284-
const [extension] = id.split(':');
285-
// load the plugin if it is built-in the notebook application explicitly
286-
// either included as an extension or as a plugin directly
287-
const hasPlugin = pluginsSet.has(extension) || pluginsSet.has(id);
288-
if (!hasPlugin || isDisabled(id) || id in settingRegistry.plugins) {
289-
return;
290-
}
291-
try {
292-
await settingRegistry.load(id);
293-
} catch (error) {
294-
console.warn(`Settings failed to load for (${id})`, error);
295-
}
296-
});
283+
await Promise.all(
284+
plugins.ids.map(async (id: string) => {
285+
const [extension] = id.split(':');
286+
// load the plugin if it is built-in the notebook application explicitly
287+
// either included as an extension or as a plugin directly
288+
const hasPlugin = pluginsSet.has(extension) || pluginsSet.has(id);
289+
if (!hasPlugin || isDisabled(id) || id in settingRegistry.plugins) {
290+
return;
291+
}
292+
try {
293+
await settingRegistry.load(id);
294+
} catch (error) {
295+
console.warn(`Settings failed to load for (${id})`, error);
296+
}
297+
})
298+
);
297299
});
298300
},
299301
};

0 commit comments

Comments
 (0)