rename test

Author: eveld

pkg/clients/container/docker_tasks_container_create_test.go

@@ -268,7 +268,7 @@ func TestContainerRollsbackWhenUnableToConnectToNetwork(t *testing.T) {
 	md.AssertCalled(t, "ContainerRemove", mock.Anything, mock.Anything, mock.Anything)
 }
 
-func TestContainerOnlyAttachesToDefaultNetworkWhenNil(t *testing.T) {
+func TestContainerDoesNOTAttachesToUserNetworkWhenNil(t *testing.T) {
 	cc, md, mic := createContainerConfig()
 	cc.Networks = []dtypes.NetworkAttachment{}
 

pkg/jumppad/engine_test.go

@@ -73,7 +73,7 @@ func TestApplyWithSingleFile(t *testing.T) {
 	_, err := e.Apply(context.Background(), "../../examples/single_file/container.hcl")
 	require.NoError(t, err)
 
-	require.Len(t, e.config.Resources, 7) // 6 resources in the file plus the image cache and default network
+	require.Len(t, e.config.Resources, 7) // 6 resources in the file plus the image cache
 
 	// Check the provider was called for each resource
 	require.ElementsMatch(t,
@@ -149,7 +149,7 @@ func TestApplyWithSingleFileAndVariables(t *testing.T) {
 
 	_, err := e.ApplyWithVariables(context.Background(), "../../examples/single_file/container.hcl", nil, "../../examples/single_file/default.vars")
 	require.NoError(t, err)
-	require.Len(t, e.config.Resources, 7) // 6 resources in the file plus the image cache and default network
+	require.Len(t, e.config.Resources, 7) // 6 resources in the file plus the image cache
 
 	// then the container should be created
 	require.Equal(t, "consul", getMetaFromMock(mp, 6).Name)
@@ -219,12 +219,12 @@ func TestApplyNotCallsProviderCreateForDisabledResources(t *testing.T) {
 	require.NoError(t, err)
 
 	// should have call create for non disabled resources
-	testAssertMethodCalled(t, mp, "Create", 3) // ImageCache and default network are always created
+	testAssertMethodCalled(t, mp, "Create", 3) // ImageCache are always created
 
 	// disabled resources should still be added to the state
 	sf := testLoadState(t)
 
-	// should contain 3 from the config plus the image cache and default network
+	// should contain 3 from the config plus the image cache
 	require.Equal(t, 4, sf.ResourceCount())
 
 	// the resource should be in the state but there should be no status
@@ -241,12 +241,12 @@ func TestApplyShouldNotAddDuplicateDisabledResources(t *testing.T) {
 	require.NoError(t, err)
 
 	// should have call create for each provider
-	testAssertMethodCalled(t, mp, "Create", 1) // ImageCache and default network are always created
+	testAssertMethodCalled(t, mp, "Create", 1) // ImageCache are always created
 
 	// disabled resources should still be added to the state
 	sf := testLoadState(t)
 
-	// should contain 3 from the config plus the image cache and default network
+	// should contain 3 from the config plus the image cache
 	// should not duplicate the disabled container as this already exists in the
 	// state
 	require.Equal(t, 4, sf.ResourceCount())
@@ -266,7 +266,7 @@ func TestApplySetsCreatedStatusForEachResource(t *testing.T) {
 	require.Equal(t, 7, e.config.ResourceCount())
 
 	// should only call create and destroy for the cache as this is pending update
-	testAssertMethodCalled(t, mp, "Create", 7) // ImageCache and default network are always created
+	testAssertMethodCalled(t, mp, "Create", 7) // ImageCache are always created
 
 	sf := testLoadState(t)
 
@@ -292,7 +292,7 @@ func TestApplyCallsProviderGenerateErrorStopsExecution(t *testing.T) {
 	// should have call create for each provider
 	// there are two top level config items, template and network
 	// network will fail
-	// ImageCache and default network should always be created
+	// ImageCache should always be created
 	testAssertMethodCalled(t, mp, "Create", 5)
 
 	sf := testLoadState(t)
@@ -320,7 +320,7 @@ func TestApplyCallsProviderDestroyAndCreateForFailedResources(t *testing.T) {
 
 	// should have call create for each provider
 	testAssertMethodCalled(t, mp, "Destroy", 1)
-	testAssertMethodCalled(t, mp, "Create", 7) // ImageCache and default network are always created
+	testAssertMethodCalled(t, mp, "Create", 7) // ImageCache are always created
 }
 
 func TestApplyCallsProviderDestroyForTaintedResources(t *testing.T) {
@@ -331,7 +331,7 @@ func TestApplyCallsProviderDestroyForTaintedResources(t *testing.T) {
 
 	// should have call create for each provider
 	testAssertMethodCalled(t, mp, "Destroy", 1)
-	testAssertMethodCalled(t, mp, "Create", 7) // ImageCache and default network are always created
+	testAssertMethodCalled(t, mp, "Create", 7) // ImageCache are always created
 }
 
 func TestApplyCallsProviderDestroyForDisabledResources(t *testing.T) {
@@ -352,7 +352,7 @@ func TestApplyCallsProviderDestroyForDisabledResources(t *testing.T) {
 
 	// should have call create for each provider
 	testAssertMethodCalled(t, mp, "Destroy", 1, r)
-	testAssertMethodCalled(t, mp, "Create", 0) // ImageCache and default network are always created
+	testAssertMethodCalled(t, mp, "Create", 0) // ImageCache are always created
 }
 
 func TestApplyCallsProviderRefreshForCreatedResources(t *testing.T) {
@@ -399,7 +399,7 @@ func TestDestroyNotCallsProviderDestroyForResourcesDisabled(t *testing.T) {
 
 	// should have call create for each provider
 	testAssertMethodCalled(t, mp, "Destroy", 2)
-	testAssertMethodCalled(t, mp, "Create", 0) // ImageCache and default network are always created
+	testAssertMethodCalled(t, mp, "Create", 0) // ImageCache are always created
 
 	// state should be removed
 	require.NoFileExists(t, utils.StatePath())