Skip to content

The regex that detects mentions is assuming English (and similar) languages #121

@yossizahn

Description

@yossizahn

The regex that detects "mentions" is assuming that an @ character is only the start of a mention if it follows a whitespace character (or a very limited number of other characters).
This assumption isn't true in other languages where a preposition may be expressed by prefixing the subject word.
e.g. In English we say "... that @xyz said..."
In Hebrew this is written as: "ש-@xyz אמר", or even as "ש@xyz אמר" without the hyphen.
I would suggest adding an allowance for hyphens at minimum.

edit: I see that Github detects all the mentions here... (sorry @xyz for awakening you from your slumber...)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions