Skip to content

fix: don't crash when basics.image is present #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2025
Merged

fix: don't crash when basics.image is present #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/i18n/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ export class Messages {
return bundle.formatPattern(message.value, attributes);
}

throw new Error('Unknown or unsupported message key specified.');
throw new Error(`Unknown or unsupported message key specified: ${key}`);
}
}
2 changes: 1 addition & 1 deletion src/resume.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<meta property="og:image" content="{{resume.basics.image}}">
<link rel="icon" href="{{resume.basics.image}}">
{{#if resume.basics.name}}
<meta property="og:image:alt" content="{{i18n "avatar" "name" resume.basics.name}}">
<meta property="og:image:alt" content="{{i18n "avatar-description" "name" resume.basics.name}}">
{{/if}}
{{/if}}

Expand Down